Summary

Wrap Request Fields dialog in Adwaita widgets

Review Request #2355 — Created March 21, 2023 and submitted March 21, 2023, 4:01 a.m.

Information

Owner

QuLogic

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

~~2362~~, ~~2361~~, ~~2359~~

Blocks

2365, 2363

Reviewers

Groups

pidgin

People

Description

This is the straightforward conversion of simply putting the existing widgets in corresponding AdwActionRow. All the different field types are not yet changed.

As an example, I have converted the boolean field to a GtkSwitch.

Testing Done

Compiled and opened Request Fields from the Demo protocol.

Commits

Summary	ID
Wrap Request Fields dialog in Adwaita widgets	c88b6f7ae86db88e159cccbe1a91b87e883f6701

Files

Issues

Description	From	Last Updated
How do we end up needing a username for an int field?	grim	March 21, 2023, 3:41 a.m.
why not bind this especially as we're already binding sensitivity	grim	March 21, 2023, 3:42 a.m.
bind?	grim	March 21, 2023, 3:42 a.m.
Oops, left this in.	QuLogic	March 21, 2023, 3:46 a.m.

pidgin/gtkrequest.c (Diff revision 1)

Show all issues

How do we end up needing a username for an int field?

QuLogic March 21, 2023, 3:37 a.m.

I'm not sure; I guess it was for something like ICQ or QQ? I kept it in because setup_entry_field was called for integer fields before.

I'm not sure if it makes much sense for the integer fields right now since they use a spin button and can't actually do completion. But it probably doesn't matter much since /r/2365 disables completion.

grim March 21, 2023, 3:42 a.m.

Great point on the removal and yeah totally forgot about ICQ, but I don't know why they wouldn't have just used a string unless using an int field made it easier to validate? I dunno, whatever...

pidgin/gtkrequest.c (Diff revision 1)

Show all issues

why not bind this especially as we're already binding sensitivity

QuLogic March 21, 2023, 3:37 a.m.

When I first tried, binding didn't work, but trying again, it looks like I need to explicitly add SYNC_CREATE.

pidgin/gtkrequest.c (Diff revision 1)
Show all issues
```
bind?
```

Change Summary:

Use property binding more.

Commits:

	Summary	ID
	Wrap Request Fields dialog in Adwaita widgets	6ee2119bb238d67d8d123ab31c07391ab31f45f5
	Wrap Request Fields dialog in Adwaita widgets	480bb9a6bb6018a787778ec4317e2b05493ece74

Diff:

Revision 2 (+412 -594)

Show changes

pidgin/gtkrequest.c

pidgin/gtkrequest.c (Diff revision 2)
Show all issues
```
Oops, left this in.
```

Ship it!

```
Ship It!
```
```
Great work, thanks!!
```

Change Summary:

Use another property binding, and remove some duplicate code.

Commits:

	Summary	ID
	Wrap Request Fields dialog in Adwaita widgets	480bb9a6bb6018a787778ec4317e2b05493ece74
	Wrap Request Fields dialog in Adwaita widgets	c88b6f7ae86db88e159cccbe1a91b87e883f6701

Diff:

Revision 3 (+404 -594)

Show changes

pidgin/gtkrequest.c

Ship it!

```
Ship It!
```

Review Board 6.0.2

Wrap Request Fields dialog in Adwaita widgets

Information

Reviewers

Change Summary:

Commits:

Diff:

Change Summary:

Commits:

Diff:

Status: Closed (submitted)