Wrap Request Fields dialog in Adwaita widgets

Review Request #2355 — Created March 21, 2023 and submitted

Information

pidgin/pidgin
default

Reviewers

This is the straightforward conversion of simply putting the existing widgets in corresponding AdwActionRow. All the different field types are not yet changed.

As an example, I have converted the boolean field to a GtkSwitch.

Compiled and opened Request Fields from the Demo protocol.

Summary ID
Wrap Request Fields dialog in Adwaita widgets
c88b6f7ae86db88e159cccbe1a91b87e883f6701

Description From Last Updated

How do we end up needing a username for an int field?

grimgrim

why not bind this especially as we're already binding sensitivity

grimgrim

bind?

grimgrim

Oops, left this in.

QuLogicQuLogic
grim
  1. 
      
  2. pidgin/gtkrequest.c (Diff revision 1)
     
     
    Show all issues

    How do we end up needing a username for an int field?

    1. I'm not sure; I guess it was for something like ICQ or QQ? I kept it in because setup_entry_field was called for integer fields before.

      I'm not sure if it makes much sense for the integer fields right now since they use a spin button and can't actually do completion. But it probably doesn't matter much since /r/2365 disables completion.

    2. Great point on the removal and yeah totally forgot about ICQ, but I don't know why they wouldn't have just used a string unless using an int field made it easier to validate? I dunno, whatever...

  3. pidgin/gtkrequest.c (Diff revision 1)
     
     
    Show all issues

    why not bind this especially as we're already binding sensitivity

    1. When I first tried, binding didn't work, but trying again, it looks like I need to explicitly add SYNC_CREATE.

  4. pidgin/gtkrequest.c (Diff revision 1)
     
     
    Show all issues

    bind?

  5. 
      
QuLogic
QuLogic
  1. 
      
  2. pidgin/gtkrequest.c (Diff revision 2)
     
     
    Show all issues

    Oops, left this in.

  3. 
      
grim
  1. Ship It!
  2. Great work, thanks!!

  3. 
      
QuLogic
grim
  1. Ship It!
  2. 
      
grim
Review request changed
Status:
Completed