Summary

Add PurpleRequest{Group,Page}:valid properties

Review Request #2348 — Created March 17, 2023 and submitted March 17, 2023, 3:51 a.m.

Owner

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

~~2351~~, ~~2346~~

Blocks

2349

Groups

People

Description

This collects the validity of the fields/groups within the group/page into a single value.

Testing Done

Compiled and ran ninja test.

Commits

Summary	ID
Add PurpleRequest{Group,Page}:valid properties This collect the validity of the fields within them into a single value.	817969f2b6a1980b76f7fb82e5397470aff25692

Issues

Description	From	Last Updated
%TRUE and %FALSE	grim	March 17, 2023, 3:49 a.m.
%TRUE and %FALSE.	grim	March 17, 2023, 3:49 a.m.

libpurple/purplerequestgroup.h (Diff revision 1)
The issue has been resolved. Show all issues
```
%TRUE and %FALSE
```
libpurple/purplerequestpage.h (Diff revision 1)
The issue has been resolved. Show all issues
```
%TRUE and %FALSE.
```

libpurple/tests/test_request_group.c (Diff revision 1)

I tend to lean towards a counter for this because otherwise you can't verify that it was called the correct number of times.

Change Summary:

Handle review comments.

Commits:

	Summary	ID
	Add PurpleRequest{Group,Page}:valid properties This collect the validity of the fields within them into a single value.	e52a13d61c8c1d5350e6491279b53fd0d1ecff0f
	Add PurpleRequest{Group,Page}:valid properties This collect the validity of the fields within them into a single value.	817969f2b6a1980b76f7fb82e5397470aff25692

Diff:

Revision 2 (+894 -36)

	finch/gntrequest.c
	libpurple/purplerequestgroup.h
	libpurple/purplerequestgroup.c
	libpurple/purplerequestpage.h
	libpurple/purplerequestpage.c
	libpurple/tests/meson.build
	libpurple/tests/test_request_group.c
	libpurple/tests/test_request_page.c
	1 more

Ship it!