Make required, but unfilled, fields invalid

Review Request #2351 — Created March 17, 2023 and submitted

Information

pidgin/pidgin
default

Reviewers

And we no longer assume that unrequired-and-unfilled fields are valid. Since there's no default validation for strings (which are currently the only fields that can be unfilled), this is automatically allowed anyway.

If still needed, this can be left up to the subclass-specific or user-supplied validation instead.

Compiled and ran ninja test.

Summary ID
Make required, but unfilled, fields invalid
a8eb36b853a97cf2b43990061d57c04e9972eaf5
Description From Last Updated

this isn't necessary

grimgrim
grim
  1. 
      
  2. Nice work, thanks!!

  3. libpurple/tests/test_request_field.c (Diff revision 1)
     
     

    this isn't necessary

  4. 
      
QuLogic
grim
  1. Ship It!
  2. 
      
grim
Review request changed

Status: Closed (submitted)

Loading...