fix issues with Qt application object in kwallet plugin

Review Request #2338 — Created March 10, 2023 and submitted

ivanhoe
pidgin/pidgin
default
pidgin
Use QGuiApplication instead of QCoreApplication to avoid runtime warning "Cannot use KWindowSystem without a QGuiApplication"
Provide argc and argv for QGuiApplication object as its documentation requires:
"The data referred to by argc and argv must stay valid for the entire lifetime of the QGuiApplication object. In addition, argc must be greater than zero and argv must contain at least one valid character string."
  • set kwallet as credential provider
  • connected account with saved credentials
  • disconnected credential provider externally
  • created and connected new account and saved credentials
  • restarted pidgin to let accounts autoconnect
Summary
fix issues with Qt application object in kwallet plugin
Description From Last Updated

can't this just be "purplekwallet", or why is the variable required?

grimgrim

could use G_N_ELEMENTS here

grimgrim

Space after comma.

QuLogicQuLogic
grim
  1. 
      
  2. can't this just be "purplekwallet", or why is the variable required?

    1. It would cause a compile warning "ISO C++ forbids converting a string constant to ‘char*’"
    2. Really? You can't typecast it or something?

    3. Yes, you can cast it. I will amend it.

  3. could use G_N_ELEMENTS here

  4. 
      
ivanhoe
QuLogic
  1. Ship It!
  2. meson.build (Diff revision 2)
     
     

    Space after comma.

  3. 
      
ivanhoe
grim
  1. Ship It!
  2. Awesome work, thanks for getting all the tweaks!!

  3. 
      
grim
Review request changed

Status: Closed (submitted)

Loading...