Summary

fix issues with Qt application object in kwallet plugin

Review Request #2338 — Created March 10, 2023 and submitted March 13, 2023, 3:24 p.m.

Information

Owner

ivanhoe

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

Use QGuiApplication instead of QCoreApplication to avoid runtime warning "Cannot use KWindowSystem without a QGuiApplication"
Provide argc and argv for QGuiApplication object as its documentation requires:
"The data referred to by argc and argv must stay valid for the entire lifetime of the QGuiApplication object. In addition, argc must be greater than zero and argv must contain at least one valid character string."

Testing Done


set kwallet as credential provider
connected account with saved credentials
disconnected credential provider externally
created and connected new account and saved credentials
restarted pidgin to let accounts autoconnect

Commits

Summary	ID
fix issues with Qt application object in kwallet plugin Use QGuiApplication instead of QCoreApplication to avoid runtime warning "Cannot use KWindowSystem without a QGuiApplication" Provide argc and argv for QGuiApplication object as its documentation requires: "The data referred to by argc and argv must stay valid for the entire lifetime of the QGuiApplication object. In addition, argc must be greater than zero and argv must contain at least one valid character string."	55d80dea916f35c4961cd74669e56f70809aa9bd

Summary

fix issues with Qt application object in kwallet plugin

Use QGuiApplication instead of QCoreApplication to avoid runtime warning "Cannot use KWindowSystem without a QGuiApplication" Provide argc and argv for QGuiApplication object as its documentation requires: "The data referred to by argc and argv must stay valid for the entire lifetime of the QGuiApplication object. In addition, argc must be greater than zero and argv must contain at least one valid character string."

55d80dea916f35c4961cd74669e56f70809aa9bd

Issues

Description	From	Last Updated
can't this just be "purplekwallet", or why is the variable required?	grim	March 13, 2023, 3:22 p.m.
could use G_N_ELEMENTS here	grim	March 11, 2023, 4:05 a.m.
Space after comma.	QuLogic	March 13, 2023, 3:22 p.m.

libpurple/plugins/kwallet/purplekwallet.cpp (Diff revision 1)

The issue has been resolved. Show all issues

can't this just be "purplekwallet", or why is the variable required?

ivanhoe March 11, 2023, 2:10 a.m.

It would cause a compile warning "ISO C++ forbids converting a string constant to ‘char*’"

grim March 11, 2023, 4:05 a.m.

Really? You can't typecast it or something?

ivanhoe March 13, 2023, 4:09 a.m.
```
Yes, you can cast it. I will amend it.
```

libpurple/plugins/kwallet/purplekwallet.cpp (Diff revision 1)
The issue has been resolved. Show all issues
```
could use G_N_ELEMENTS here
```

Change Summary:

use G_N_ELEMENTS to set argc

Commits:

	Summary	ID
	fix issues with Qt application object in kwallet plugin Use QGuiApplication instead of QCoreApplication to avoid runtime warning "Cannot use KWindowSystem without a QGuiApplication" Provide argc and argv for QGuiApplication object as its documentation requires: "The data referred to by argc and argv must stay valid for the entire lifetime of the QGuiApplication object. In addition, argc must be greater than zero and argv must contain at least one valid character string."	855138d516e08f6c6f5be38506a20e7a633c8e9e
	fix issues with Qt application object in kwallet plugin Use QGuiApplication instead of QCoreApplication to avoid runtime warning "Cannot use KWindowSystem without a QGuiApplication" Provide argc and argv for QGuiApplication object as its documentation requires: "The data referred to by argc and argv must stay valid for the entire lifetime of the QGuiApplication object. In addition, argc must be greater than zero and argv must contain at least one valid character string."	35366ea9489c32dd7dc11ebb992acb2adb22b770

Diff:

Revision 2 (+28 -20)

Show changes

	meson.build
	libpurple/plugins/kwallet/purplekwallet.cpp

Ship it!

```
Ship It!
```
meson.build (Diff revision 2)
The issue has been resolved. Show all issues
```
Space after comma.
```

Commits:

	Summary	ID
	fix issues with Qt application object in kwallet plugin Use QGuiApplication instead of QCoreApplication to avoid runtime warning "Cannot use KWindowSystem without a QGuiApplication" Provide argc and argv for QGuiApplication object as its documentation requires: "The data referred to by argc and argv must stay valid for the entire lifetime of the QGuiApplication object. In addition, argc must be greater than zero and argv must contain at least one valid character string."	35366ea9489c32dd7dc11ebb992acb2adb22b770
	fix issues with Qt application object in kwallet plugin Use QGuiApplication instead of QCoreApplication to avoid runtime warning "Cannot use KWindowSystem without a QGuiApplication" Provide argc and argv for QGuiApplication object as its documentation requires: "The data referred to by argc and argv must stay valid for the entire lifetime of the QGuiApplication object. In addition, argc must be greater than zero and argv must contain at least one valid character string."	55d80dea916f35c4961cd74669e56f70809aa9bd

Diff:

Revision 3 (+26 -20)

Show changes

	meson.build
	libpurple/plugins/kwallet/purplekwallet.cpp

Ship it!

```
Ship It!
```

Awesome work, thanks for getting all the tweaks!!

Status:: Completed