Summary

Embed PidginAccountEditor into PidginAccountManager

Review Request #2333 — Created March 10, 2023 and submitted March 16, 2023, 10:40 p.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

The account manager now uses a stack to switch between a single editor instance
and the list of accounts. The save button from the editor got moved next to the
new back button, but we should probably prompt or throw up an info box when the
user starts making changes or prompt before moving back.

Also, the app.edit-account action now will lose any changes to an account that
is currently being edited, which we should disallow from happening in the future
as well.

Testing Done

Opened the account manager and selected accounts and moved backed and saved accounts and made sure everything there worked.
Opened the account editor from a connection error notification and verified that opened properly as well.

Commits

Summary	ID
Embed PidginAccountEditor into PidginAccountManager The account manager now uses a stack to switch between a single editor instance and the list of accounts. The save button from the editor got moved next to the new back button, but we should probably prompt or throw up an info box when the user starts making changes or prompt before moving back. Also, the app.edit-account action now will lose any changes to an account that is currently being edited, which we should disallow from happening in the future as well.	1f62cecf2450cf0f792d15d628d9a99d5c7a341b

Summary

Embed PidginAccountEditor into PidginAccountManager

The account manager now uses a stack to switch between a single editor instance and the list of accounts. The save button from the editor got moved next to the new back button, but we should probably prompt or throw up an info box when the user starts making changes or prompt before moving back. Also, the app.edit-account action now will lose any changes to an account that is currently being edited, which we should disallow from happening in the future as well.

1f62cecf2450cf0f792d15d628d9a99d5c7a341b

Files

Issues

Description	From	Last Updated
We need to disconnect this signal from the old account now, don't we?	QuLogic	March 16, 2023, 9:57 p.m.
Extra space after if.	QuLogic	March 16, 2023, 9:55 p.m.
Somewhat redundant comment; maybe it should say "Disconnect the editor fields from the account" or something like that.	QuLogic	March 16, 2023, 9:57 p.m.
We probably need some additional state here for where the window came from. That is, if you go to Accounts->account->Edit …	QuLogic	March 16, 2023, 10:01 p.m.
This is only ever called for an existing account now that purple_account_manager_real_edit_account is what's internally called in account manager. Should …	QuLogic	March 16, 2023, 10:20 p.m.

pidgin/pidginaccounteditor.c (Diff revision 1)

Show all issues

We need to disconnect this signal from the old account now, don't we?

pidgin/pidginaccounteditor.c (Diff revision 1)
Show all issues
```
Extra space after if.
```

pidgin/pidginaccountmanager.c (Diff revision 1)

Show all issues

Somewhat redundant comment; maybe it should say "Disconnect the editor fields from the account" or something like that.

pidgin/pidginaccountmanager.c (Diff revision 1)

Show all issues

We probably need some additional state here for where the window came from. That is, if you go to Accounts->account->Edit Account, you probably don't want to go back to the account manager after saving.

grim March 16, 2023, 8:46 p.m.
```
Thats a great point!
```

Change Summary:

rebase, address issues, and try to work out more of the flow when editing accounts separately.

Commits:

	Summary	ID
	Embed PidginAccountEditor into PidginAccountManager The account manager now uses a stack to switch between a single editor instance and the list of accounts. The save button from the editor got moved next to the new back button, but we should probably prompt or throw up an info box when the user starts making changes or prompt before moving back. Also, the app.edit-account action now will lose any changes to an account that is currently being edited, which we should disallow from happening in the future as well.	f29134f2eed2638b30090f590f2383c701441109
	Embed PidginAccountEditor into PidginAccountManager The account manager now uses a stack to switch between a single editor instance and the list of accounts. The save button from the editor got moved next to the new back button, but we should probably prompt or throw up an info box when the user starts making changes or prompt before moving back. Also, the app.edit-account action now will lose any changes to an account that is currently being edited, which we should disallow from happening in the future as well.	eb99bc766ff1aa85446937d5d50d4dc15f2bb81b

Diff:

Revision 2 (+1084 -624)

Show changes

	pidgin/pidginaccounteditor.h
	pidgin/pidginaccounteditor.c
	pidgin/pidginaccountmanager.h
	pidgin/pidginaccountmanager.c
	pidgin/pidginapplication.c
	pidgin/resources/Accounts/editor.ui
	pidgin/resources/Accounts/manager.ui

pidgin/pidginaccountmanager.h (Diff revision 2)

Show all issues

This is only ever called for an existing account now that purple_account_manager_real_edit_account is what's internally called in account manager.

Should account no longer be (nullable), or do we expect anywhere else to request adding a new account?

Change Summary:

remove nullable from the account for pidgin_account_manager_edit_account and add some type checking on the parameter for the edit account action

Commits:

	Summary	ID
	Embed PidginAccountEditor into PidginAccountManager The account manager now uses a stack to switch between a single editor instance and the list of accounts. The save button from the editor got moved next to the new back button, but we should probably prompt or throw up an info box when the user starts making changes or prompt before moving back. Also, the app.edit-account action now will lose any changes to an account that is currently being edited, which we should disallow from happening in the future as well.	eb99bc766ff1aa85446937d5d50d4dc15f2bb81b
	Embed PidginAccountEditor into PidginAccountManager The account manager now uses a stack to switch between a single editor instance and the list of accounts. The save button from the editor got moved next to the new back button, but we should probably prompt or throw up an info box when the user starts making changes or prompt before moving back. Also, the app.edit-account action now will lose any changes to an account that is currently being edited, which we should disallow from happening in the future as well.	1f62cecf2450cf0f792d15d628d9a99d5c7a341b

Diff:

Revision 3 (+1102 -624)

Show changes

	pidgin/pidginaccounteditor.h
	pidgin/pidginaccounteditor.c
	pidgin/pidginaccountmanager.h
	pidgin/pidginaccountmanager.c
	pidgin/pidginapplication.c
	pidgin/resources/Accounts/editor.ui
	pidgin/resources/Accounts/manager.ui

Ship it!

```
Ship It!
```

Review Board 6.0.2

Embed PidginAccountEditor into PidginAccountManager

Information

Reviewers

Change Summary:

Commits:

Diff:

Change Summary:

Commits:

Diff:

Status: Closed (submitted)