-
-
pidgin/pidginaccounteditor.c (Diff revision 1) We need to disconnect this signal from the old account now, don't we?
-
-
pidgin/pidginaccountmanager.c (Diff revision 1) Somewhat redundant comment; maybe it should say "Disconnect the editor fields from the account" or something like that.
-
pidgin/pidginaccountmanager.c (Diff revision 1) We probably need some additional state here for where the window came from. That is, if you go to
Accounts->account->Edit Account, you probably don't want to go back to the account manager after saving.
Embed PidginAccountEditor into PidginAccountManager
Review Request #2333 — Created March 10, 2023 and submitted
| Information | |
|---|---|
| grim | |
| pidgin/pidgin | |
| default | |
| Reviewers | |
| pidgin | |
The account manager now uses a stack to switch between a single editor instance and the list of accounts. The save button from the editor got moved next to the new back button, but we should probably prompt or throw up an info box when the user starts making changes or prompt before moving back. Also, the app.edit-account action now will lose any changes to an account that is currently being edited, which we should disallow from happening in the future as well.
Opened the account manager and selected accounts and moved backed and saved accounts and made sure everything there worked.
Opened the account editor from a connection error notification and verified that opened properly as well.
| Summary | |
|---|---|
| Description | From | Last Updated |
|---|---|---|
|
We need to disconnect this signal from the old account now, don't we? |
 QuLogic
|
|
|
Extra space after if. |
QuLogic
|
|
|
Somewhat redundant comment; maybe it should say "Disconnect the editor fields from the account" or something like that. |
QuLogic
|
|
|
We probably need some additional state here for where the window came from. That is, if you go to Accounts->account->Edit … |
QuLogic
|
|
|
This is only ever called for an existing account now that purple_account_manager_real_edit_account is what's internally called in account manager. Should … |
QuLogic
|
Change Summary:
rebase, address issues, and try to work out more of the flow when editing accounts separately.
Commits: |
|
|||||||||
|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+1084 -624) |
|||||||||
-
-
pidgin/pidginaccountmanager.h (Diff revision 2) This is only ever called for an existing account now that
purple_account_manager_real_edit_accountis what's internally called in account manager.Should
accountno longer be(nullable), or do we expect anywhere else to request adding a new account?
Change Summary:
remove nullable from the account for pidgin_account_manager_edit_account and add some type checking on the parameter for the edit account action
Commits: |
|
|||||||||
|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 3 (+1102 -624) |
|||||||||