Convert PurpleRequestPage into a GObject

Review Request #2323 — Created March 7, 2023 and submitted

Information

pidgin/pidgin
default

Reviewers

And rename it from PurpleRequestFields.

Also, implements GListModel for the groups, but nothing uses it that way get.

Compiled, and opened Request Fields from Demo protocol.

Summary ID
Convert PurpleRequestPage into a GObject
And rename it from PurpleRequestFields.
ed1cd011456befe5f3ca482b6087d6eefa18e72e
Description From Last Updated

fields are gobjects now right? shouldn't the value destructor be g_object_unref?

grimgrim

extra whitespace before screenname

grimgrim
grim
  1. 
      
  2. libpurple/purplerequestpage.c (Diff revision 1)
     
     
    Show all issues

    fields are gobjects now right? shouldn't the value destructor be g_object_unref?

    1. Yes, but they're owned by the group, not the page, and they can't be removed, so the page doesn't have a ref. We could probably change this.

    2. Oh okay, cool!

  3. pidgin/gtkdialogs.c (Diff revision 1)
     
     
    Show all issues

    extra whitespace before screenname

    1. ignoring this for now as it'll get rewritten soon enough.

  4. 
      
grim
  1. Ship It!
  2. 
      
grim
Review request changed
Status:
Completed