Summary

Convert PurpleRequestPage into a GObject

Review Request #2323 — Created March 7, 2023 and submitted March 7, 2023, 7:05 a.m.

Owner

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

~~2322~~

Blocks

2327

Groups

People

Description

And rename it from PurpleRequestFields.

Also, implements GListModel for the groups, but nothing uses it that way get.

Testing Done

Compiled, and opened Request Fields from Demo protocol.

Commits

Summary	ID
Convert PurpleRequestPage into a GObject And rename it from PurpleRequestFields.	ed1cd011456befe5f3ca482b6087d6eefa18e72e

Issues

Description	From	Last Updated
fields are gobjects now right? shouldn't the value destructor be g_object_unref?	grim	March 7, 2023, 6:59 a.m.
extra whitespace before screenname	grim	March 7, 2023, 7:01 a.m.

libpurple/purplerequestpage.c (Diff revision 1)

Show all issues

fields are gobjects now right? shouldn't the value destructor be g_object_unref?

Yes, but they're owned by the group, not the page, and they can't be removed, so the page doesn't have a ref. We could probably change this.

pidgin/gtkdialogs.c (Diff revision 1)

Show all issues

extra whitespace before screenname

ignoring this for now as it'll get rewritten soon enough.

Ship it!

Review Board 6.0.2