Propagate the notify signal for the Presence object on a ContactInfo

Review Request #2306 — Created March 3, 2023 and submitted

Information

pidgin/pidgin
default

Reviewers

Propagate the notify signal for the Presence object on a ContactInfo

Ran the unit tests under valgrind and verified now no leaks.
Also checked the docs and made sure the signal was documented properly.

Summary ID
Propagate the notify signal for the Presence object on a ContactInfo
69593936db009f0c978e323fe3ef2e5a86606258
Description From Last Updated

../libpurple/purplecontactinfo.c:136: Error: Purple: identifier not found on the first line: * This is a notify callback on the presence for …

ivanhoeivanhoe

Should this maybe follow the naming of the documentation of the presence-changed signal, i.e., contact instead of info?

ivanhoeivanhoe

double the

ivanhoeivanhoe
grim
  1. 
      
  2. I need a test comment...

  3. 
      
ivanhoe
  1. 
      
  2. libpurple/purplecontactinfo.c (Diff revision 1)
     
     
    Show all issues

    ../libpurple/purplecontactinfo.c:136: Error: Purple: identifier not found on the first line:
     * This is a notify callback on the presence for a contact info, it is used
       ^
    
  3. libpurple/tests/test_contact_info.c (Diff revision 1)
     
     
    Show all issues

    Should this maybe follow the naming of the documentation of the presence-changed signal, i.e., contact instead of info?

    1. Took me a minute to realize you were talking about the name of the parameter :-D But actually the signal should be updated to say info because PurpleContact is a thing, so this should either be contact_info or info and I'm going to go for less typing :-D

  4. libpurple/tests/test_contact_info.c (Diff revision 1)
     
     
    Show all issues

    double the

  5. 
      
grim
ivanhoe
  1. Ship It!
  2. 
      
grim
Review request changed
Status:
Completed