Propagate the notify signal for the Presence object on a ContactInfo
Review Request #2306 — Created March 3, 2023 and submitted
Propagate the notify signal for the Presence object on a ContactInfo
Ran the unit tests under valgrind and verified now no leaks.
Also checked the docs and made sure the signal was documented properly.
| Summary | ID |
|---|---|
| 69593936db009f0c978e323fe3ef2e5a86606258 |
| Description | From | Last Updated |
|---|---|---|
|
../libpurple/purplecontactinfo.c:136: Error: Purple: identifier not found on the first line: * This is a notify callback on the presence for … |
 ivanhoe
|
|
|
Should this maybe follow the naming of the documentation of the presence-changed signal, i.e., contact instead of info? |
ivanhoe
|
|
|
double the |
ivanhoe
|
-
-
libpurple/purplecontactinfo.c (Diff revision 1) ../libpurple/purplecontactinfo.c:136: Error: Purple: identifier not found on the first line: * This is a notify callback on the presence for a contact info, it is used ^ -
libpurple/tests/test_contact_info.c (Diff revision 1) Should this maybe follow the naming of the documentation of the presence-changed signal, i.e.,
contactinstead ofinfo? -
Change Summary:
rebase and address issues
Commits: |
|
|||||||
|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+210) |