Summary

Propagate the notify signal for the Presence object on a ContactInfo

Review Request #2306 — Created March 3, 2023 and submitted March 3, 2023, 4:49 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

Propagate the notify signal for the Presence object on a ContactInfo

Testing Done

Ran the unit tests under valgrind and verified now no leaks.
Also checked the docs and made sure the signal was documented properly.

Commits

Summary	ID
Propagate the notify signal for the Presence object on a ContactInfo	69593936db009f0c978e323fe3ef2e5a86606258

Issues

Description	From	Last Updated
../libpurple/purplecontactinfo.c:136: Error: Purple: identifier not found on the first line: * This is a notify callback on the presence for …	ivanhoe	March 3, 2023, 4:11 a.m.
Should this maybe follow the naming of the documentation of the presence-changed signal, i.e., contact instead of info?	ivanhoe	March 3, 2023, 4:11 a.m.
double the	ivanhoe	March 3, 2023, 4:11 a.m.

```
I need a test comment...
```

libpurple/purplecontactinfo.c (Diff revision 1)

The issue has been resolved. Show all issues

../libpurple/purplecontactinfo.c:136: Error: Purple: identifier not found on the first line:
 * This is a notify callback on the presence for a contact info, it is used
   ^

libpurple/tests/test_contact_info.c (Diff revision 1)

The issue has been resolved. Show all issues

Should this maybe follow the naming of the documentation of the presence-changed signal, i.e., contact instead of info?

grim March 3, 2023, 3:54 a.m.

Took me a minute to realize you were talking about the name of the parameter :-D But actually the signal should be updated to say info because PurpleContact is a thing, so this should either be contact_info or info and I'm going to go for less typing :-D

libpurple/tests/test_contact_info.c (Diff revision 1)
The issue has been resolved. Show all issues
```
double the
```

Change Summary:

rebase and address issues

Commits:

	Summary	ID
	Propagate the notify signal for the Presence object on a ContactInfo	c39aa6e61b8e755ee7513f4be6abbc2059022739
	Propagate the notify signal for the Presence object on a ContactInfo	69593936db009f0c978e323fe3ef2e5a86606258

Diff:

Revision 2 (+210)

Show changes

	libpurple/purplecontactinfo.c
	libpurple/tests/test_contact_info.c

Ship it!

```
Ship It!
```

Status:: Completed