Add demo of requests API to demo protocol

Review Request #2289 — Created Feb. 26, 2023 and submitted

Information

pidgin/pidgin
default

Reviewers

This provides actions that trigger all of the request API, except for datasheets, which are quite complex.

We could do something fancy like have this trigger something with the demo contacts, but all this does is print a debug message with the results.

Opened all added menu items and confirmed that the correct thing was printed out as input, or that a cancellation was printed.

Summary ID
Add demo of requests API to demo protocol
ac52f2b95604ae65e64a6a26d82850b75a1f18b1

Description From Last Updated

I forgot to go back and mark everything for translation; not sure if I should bother.

QuLogicQuLogic

g_critical isn't fatal, so we should probably return here.

grimgrim

What's the goal of this math here? masked is true on evens, but multiline is true like 1/4th the time? …

grimgrim

Should return here

grimgrim

Needs a return

grimgrim

Needs a return

grimgrim

Needs a return

grimgrim

Needs a return

grimgrim
QuLogic
  1. 
      
  2. Show all issues

    I forgot to go back and mark everything for translation; not sure if I should bother.

    1. If it's not too big of an ask that would be preferred. I've been working under the idea that we'd used the demo plugin to do the first run tour thing, so it might be nice if users are just randomly exploring.

  3. 
      
grim
  1. 
      
  2. Show all issues

    g_critical isn't fatal, so we should probably return here.

  3. Show all issues

    What's the goal of this math here? masked is true on evens, but multiline is true like 1/4th the time? Either way a comment might be helpful here.

    1. There are 4 combinations, multiline stays the same for every pair of masked.

  4. Show all issues

    Should return here

  5. Show all issues

    Needs a return

  6. Show all issues

    Needs a return

  7. Show all issues

    Needs a return

  8. Great ranges!

  9. Show all issues

    Needs a return

  10. 
      
QuLogic
grim
  1. Ship It!
  2. Great work! Thank you so much!!

  3. 
      
grim
Review request changed
Status:
Completed