Add demo of requests API to demo protocol
Review Request #2289 — Created Feb. 25, 2023 and submitted
| Information | |
|---|---|
| QuLogic | |
| pidgin/pidgin | |
| default | |
| Reviewers | |
| pidgin | |
This provides actions that trigger all of the request API, except for datasheets, which are quite complex.
We could do something fancy like have this trigger something with the demo contacts, but all this does is print a debug message with the results.
Opened all added menu items and confirmed that the correct thing was printed out as input, or that a cancellation was printed.
| Summary |
|---|
| Description | From | Last Updated |
|---|---|---|
|
I forgot to go back and mark everything for translation; not sure if I should bother. |
 QuLogic
|
|
|
g_critical isn't fatal, so we should probably return here. |
 grim
|
|
|
What's the goal of this math here? masked is true on evens, but multiline is true like 1/4th the time? … |
grim
|
|
|
Should return here |
grim
|
|
|
Needs a return |
grim
|
|
|
Needs a return |
grim
|
|
|
Needs a return |
grim
|
|
|
Needs a return |
grim
|
-
-
libpurple/protocols/demo/purpledemoprotocolactions.c (Diff revision 1) g_criticalisn't fatal, so we should probably return here. -
libpurple/protocols/demo/purpledemoprotocolactions.c (Diff revision 1) What's the goal of this math here?
maskedis true on evens, but multiline is true like 1/4th the time? Either way a comment might be helpful here. -
-
-
-
-
-
Change Summary:
Add
returns and mark strings for translation.
Commits: |
|
||||||
|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+1200 -68) |