Summary

Add demo of requests API to demo protocol

Review Request #2289 — Created Feb. 26, 2023 and submitted Feb. 26, 2023, 7:31 a.m.

Information

Owner

QuLogic

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

This provides actions that trigger all of the request API, except for datasheets, which are quite complex.

We could do something fancy like have this trigger something with the demo contacts, but all this does is print a debug message with the results.

Testing Done

Opened all added menu items and confirmed that the correct thing was printed out as input, or that a cancellation was printed.

Commits

Summary	ID
Add demo of requests API to demo protocol	ac52f2b95604ae65e64a6a26d82850b75a1f18b1

Files

Issues

Description	From	Last Updated
I forgot to go back and mark everything for translation; not sure if I should bother.	QuLogic	Feb. 26, 2023, 7:30 a.m.
g_critical isn't fatal, so we should probably return here.	grim	Feb. 26, 2023, 7:30 a.m.
What's the goal of this math here? masked is true on evens, but multiline is true like 1/4th the time? …	grim	Feb. 26, 2023, 7:30 a.m.
Should return here	grim	Feb. 26, 2023, 7:30 a.m.
Needs a return	grim	Feb. 26, 2023, 7:30 a.m.
Needs a return	grim	Feb. 26, 2023, 7:30 a.m.
Needs a return	grim	Feb. 26, 2023, 7:30 a.m.
Needs a return	grim	Feb. 26, 2023, 7:30 a.m.

The issue has been resolved. Show all issues

I forgot to go back and mark everything for translation; not sure if I should bother.

grim Feb. 26, 2023, 5:50 a.m.

If it's not too big of an ask that would be preferred. I've been working under the idea that we'd used the demo plugin to do the first run tour thing, so it might be nice if users are just randomly exploring.

libpurple/protocols/demo/purpledemoprotocolactions.c (Diff revision 1)
The issue has been resolved. Show all issues
```
g_critical isn't fatal, so we should probably return here.
```

libpurple/protocols/demo/purpledemoprotocolactions.c (Diff revision 1)

The issue has been resolved. Show all issues

What's the goal of this math here? masked is true on evens, but multiline is true like 1/4th the time? Either way a comment might be helpful here.

QuLogic Feb. 26, 2023, 6:30 a.m.

There are 4 combinations, multiline stays the same for every pair of masked.

libpurple/protocols/demo/purpledemoprotocolactions.c (Diff revision 1)
The issue has been resolved. Show all issues
```
Should return here
```
libpurple/protocols/demo/purpledemoprotocolactions.c (Diff revision 1)
The issue has been resolved. Show all issues
```
Needs a return
```
libpurple/protocols/demo/purpledemoprotocolactions.c (Diff revision 1)
The issue has been resolved. Show all issues
```
Needs a return
```
libpurple/protocols/demo/purpledemoprotocolactions.c (Diff revision 1)
The issue has been resolved. Show all issues
```
Needs a return
```
libpurple/protocols/demo/purpledemoprotocolactions.c (Diff revision 1)
```
Great ranges!
```
libpurple/protocols/demo/purpledemoprotocolactions.c (Diff revision 1)
The issue has been resolved. Show all issues
```
Needs a return
```

Change Summary:

Add returns and mark strings for translation.

Commits:

	Summary	ID
	Add demo of requests API to demo protocol	c656e0c2a223380b6e536a3c60ff591821cd615c
	Add demo of requests API to demo protocol	ac52f2b95604ae65e64a6a26d82850b75a1f18b1

Diff:

Revision 2 (+1200 -68)

Show changes

libpurple/protocols/demo/purpledemoprotocolactions.c

Ship it!

```
Ship It!
```
```
Great work! Thank you so much!!
```

Status:: Completed