-
-
-
libpurple/purpleconversation.h (Diff revision 1) For out, it should be
(optional)instead of(nullable); the latter means the result may beNULL(which doesn't make sense for aguint.) -
-
-
-
-
-
libpurple/tests/test_conversation.c (Diff revision 1) Is there a reason it's not
==, PURPLE_CONNECTION_FLAG_HTML)?
Add membership management to PurpleConversation
Review Request #2287 — Created Feb. 25, 2023 and submitted
| Information | |
|---|---|
| grim | |
| pidgin/pidgin | |
| default | |
| PIDGIN-17768 | |
| Reviewers | |
| pidgin | |
This is one of many steps to making PurpleConversation handle all conversation types instead of being an abstract class. In modern chat protocols the only distinction between different types of conversations is an enum property and members can join and leave dms, group dms, and multiple user chats. As such this change is necessary to facilitate that.
Ran the unit tests under valgrind and built and verified the docs looked alright.
| Summary | |
|---|---|
| Description | From | Last Updated |
|---|---|---|
|
s/who // |
 QuLogic
|
|
|
For out, it should be (optional) instead of (nullable); the latter means the result may be NULL (which doesn't make … |
QuLogic
|
|
|
(nullable)? |
QuLogic
|
|
|
= {0, }; usually? |
QuLogic
|
|
|
s/join/addition/ for consistency. |
QuLogic
|
|
|
s/part/removal/ for consistency |
QuLogic
|
|
|
enough |
QuLogic
|
|
|
Is there a reason it's not ==, PURPLE_CONNECTION_FLAG_HTML)? |
QuLogic
|
Change Summary:
rebase and address issues.
Commits: |
|
|||||||||
|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+1082 -104) |
|||||||||