Summary

Add membership management to PurpleConversation

Review Request #2287 — Created Feb. 25, 2023 and submitted March 3, 2023, 7:26 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

PIDGIN-17768

Depends On

Reviewers

Groups

pidgin

People

Description

This is one of many steps to making PurpleConversation handle all conversation
types instead of being an abstract class. In modern chat protocols the only
distinction between different types of conversations is an enum property and
members can join and leave dms, group dms, and multiple user chats. As such
this change is necessary to facilitate that.

Testing Done

Ran the unit tests under valgrind and built and verified the docs looked alright.

Commits

Summary	ID
Add membership management to PurpleConversation This is one of many steps to making PurpleConversation handle all conversation types instead of being an abstract class. In modern chat protocols the only distinction between different types of conversations is an enum property and members can join and leave dms, group dms, and multiple user chats. As such this change is necessary to facilitate that.	8e36f27cf1f4be16fed1aa17cff7b696b054e738

Summary

Add membership management to PurpleConversation

This is one of many steps to making PurpleConversation handle all conversation types instead of being an abstract class. In modern chat protocols the only distinction between different types of conversations is an enum property and members can join and leave dms, group dms, and multiple user chats. As such this change is necessary to facilitate that.

8e36f27cf1f4be16fed1aa17cff7b696b054e738

Issues

Description	From	Last Updated
s/who //	QuLogic	March 3, 2023, 7:23 a.m.
For out, it should be (optional) instead of (nullable); the latter means the result may be NULL (which doesn't make …	QuLogic	March 3, 2023, 7:23 a.m.
(nullable)?	QuLogic	March 3, 2023, 7:23 a.m.
= {0, }; usually?	QuLogic	March 3, 2023, 7:23 a.m.
s/join/addition/ for consistency.	QuLogic	March 3, 2023, 7:23 a.m.
s/part/removal/ for consistency	QuLogic	March 3, 2023, 7:24 a.m.
enough	QuLogic	March 3, 2023, 7:24 a.m.
Is there a reason it's not ==, PURPLE_CONNECTION_FLAG_HTML)?	QuLogic	March 3, 2023, 7:24 a.m.

libpurple/purpleconversation.h (Diff revision 1)
The issue has been resolved. Show all issues
```
s/who //
```

libpurple/purpleconversation.h (Diff revision 1)

The issue has been resolved. Show all issues

For out, it should be (optional) instead of (nullable); the latter means the result may be NULL (which doesn't make sense for a guint.)

libpurple/purpleconversation.h (Diff revision 1)
The issue has been resolved. Show all issues
```
(nullable)?
```
libpurple/purpleconversation.c (Diff revision 1)
The issue has been resolved. Show all issues
```
= {0, }; usually?
```
libpurple/purpleconversation.c (Diff revision 1)
The issue has been resolved. Show all issues
```
s/join/addition/ for consistency.
```
libpurple/purpleconversation.c (Diff revision 1)
The issue has been resolved. Show all issues
```
s/part/removal/ for consistency
```
libpurple/purpleconversation.c (Diff revision 1)
The issue has been resolved. Show all issues
```
enough
```
libpurple/tests/test_conversation.c (Diff revision 1)
The issue has been resolved. Show all issues
```
Is there a reason it's not ==, PURPLE_CONNECTION_FLAG_HTML)?
```

Change Summary:

rebase and address issues.

Commits:

	Summary	ID
	Add membership management to PurpleConversation This is one of many steps to making PurpleConversation handle all conversation types instead of being an abstract class. In modern chat protocols the only distinction between different types of conversations is an enum property and members can join and leave dms, group dms, and multiple user chats. As such this change is necessary to facilitate that.	65d84eaa9be4d151dca5852e0ebcdb69ca79625b
	Add membership management to PurpleConversation This is one of many steps to making PurpleConversation handle all conversation types instead of being an abstract class. In modern chat protocols the only distinction between different types of conversations is an enum property and members can join and leave dms, group dms, and multiple user chats. As such this change is necessary to facilitate that.	8e36f27cf1f4be16fed1aa17cff7b696b054e738

Diff:

Revision 2 (+1082 -104)

Show changes

	libpurple/purpleconversation.h
	libpurple/purpleconversation.c
	libpurple/tests/meson.build
	libpurple/tests/test_conversation.c

Ship it!

```
Ship It!
```

Status:: Completed