- Download Diff

Summary:

Mark unused parameters as such for all finch

Review Request #2254 — Created Feb. 20, 2023 and submitted Feb. 23, 2023, 7:33 a.m.

Information
Owner:	grim
Repository:	pidgin/pidgin
Branch:	default
Bugs:
Depends On:
Reviewers
Groups:	pidgin
People:

Description

Mark unused parameters as such for all finch

Testing Done

Turned the warning level up to 2, compiled, and verified the warnings were gone.

Commits

Summary
Mark unused parameters as such for all finch

Screenshots

Issues

Description	From	Last Updated
Not sure if this is within the scope of this RR but there are still unused parameters in the finch …	ivanhoe	Feb. 23, 2023, 7:13 a.m.
data is used	ivanhoe	Feb. 23, 2023, 6:15 a.m.
Analogous to above function, null could be renamed to data.	ivanhoe	Feb. 23, 2023, 6:18 a.m.
s/null/data ?	ivanhoe	Feb. 23, 2023, 6:17 a.m.
data unused	ivanhoe	Feb. 23, 2023, 7:05 a.m.
data unused	ivanhoe	Feb. 23, 2023, 7:05 a.m.
flags and data unused	ivanhoe	Feb. 23, 2023, 7:06 a.m.
account, flags, and data unused	ivanhoe	Feb. 23, 2023, 7:07 a.m.
data unused	ivanhoe	Feb. 23, 2023, 7:08 a.m.
error unused	ivanhoe	Feb. 23, 2023, 7:08 a.m.
error unused	ivanhoe	Feb. 23, 2023, 7:08 a.m.
All parameters unused	ivanhoe	Feb. 23, 2023, 7:08 a.m.
cmd, error, and data unused	ivanhoe	Feb. 23, 2023, 7:09 a.m.
error unused	ivanhoe	Feb. 23, 2023, 7:09 a.m.
plugin and error unused	ivanhoe	Feb. 23, 2023, 7:09 a.m.
plugin, shutdown, and error unused	ivanhoe	Feb. 23, 2023, 7:09 a.m.

finch/gntblist.c (Diff revision 1)
Show all issues
```
data is used
```

finch/gntroomlist.c (Diff revision 1)

Show all issues

Analogous to above function, null could be renamed to data.

finch/gntroomlist.c (Diff revision 1)
Show all issues
```
s/null/data ?
```

Change Summary:

rebased, addressed issues, s/gpointer null/gpointer/data/g

Commits:

	Summary
-	Mark unused parameters as such for all finch
+	Mark unused parameters as such for all finch

Diff:

Revision 2 (+554 -394)

Show changes

	finch/finchnotifications.c
	finch/gntaccount.c
	finch/gntblist.c
	finch/gntconn.c
	finch/gntconv.c
	finch/gntdebug.c
	finch/gntidle.c
	finch/gntmedia.c
	9 more

Show all issues

Not sure if this is within the scope of this RR but there are still unused parameters in the finch plugins gntclipboard, gnttinyurl, and grouping.

grim Feb. 23, 2023, 6:59 a.m.

I meant back to get the plugins and clearly forgot..

finch/plugins/gntgf/gntgf.c (Diff revision 2)
Show all issues
```
data unused
```
finch/plugins/gntgf/gntgf.c (Diff revision 2)
Show all issues
```
data unused
```
finch/plugins/gntgf/gntgf.c (Diff revision 2)
Show all issues
```
flags and data unused
```
finch/plugins/gntgf/gntgf.c (Diff revision 2)
Show all issues
```
account, flags, and data unused
```
finch/plugins/gntgf/gntgf.c (Diff revision 2)
Show all issues
```
data unused
```
finch/plugins/gntgf/gntgf.c (Diff revision 2)
Show all issues
```
error unused
```
finch/plugins/gntgf/gntgf.c (Diff revision 2)
Show all issues
```
error unused
```
finch/plugins/gntgf/gntgf.c (Diff revision 2)
Show all issues
```
All parameters unused
```
finch/plugins/lastlog/lastlog.c (Diff revision 2)
Show all issues
```
cmd, error, and data unused
```
finch/plugins/lastlog/lastlog.c (Diff revision 2)
Show all issues
```
error unused
```
finch/plugins/lastlog/lastlog.c (Diff revision 2)
Show all issues
```
plugin and error unused
```
finch/plugins/lastlog/lastlog.c (Diff revision 2)
Show all issues
```
plugin, shutdown, and error unused
```

Change Summary:

Got all the things. Used find finch/ -iname "*.c" -execdir touch {} \; to verify before building

Commits:

	Summary
-	Mark unused parameters as such for all finch
+	Mark unused parameters as such for all finch

Diff:

Revision 3 (+644 -442)

Show changes

	finch/finchnotifications.c
	finch/gntaccount.c
	finch/gntblist.c
	finch/gntconn.c
	finch/gntconv.c
	finch/gntdebug.c
	finch/gntidle.c
	finch/gntmedia.c
	12 more

Ship it!

```
Ship It!
```

You have a pending review.

Review Board 5.0.3

Mark unused parameters as such for all finch

Change Summary:

Commits:

Diff:

Change Summary:

Commits:

Diff:

Status: Closed (submitted)