Summary

Add an error property to PurpleMessage

Review Request #2234 — Created Feb. 10, 2023 and submitted Feb. 23, 2023, 7:01 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

PIDGIN-17757

Depends On

Reviewers

Groups

pidgin

People

Description

There are a number of ways that an individual message can fail, and it would be
nice to let the user interface know that it failed, so that the user can attempt
to resend.

Testing Done

Ran the unit tests (that I just added)

Commits

Summary	ID
Add an error property to PurpleMessage There are a number of ways that an individual message can fail, and it would be nice to let the user interface know that it failed, so that the user can attempt to resend.	0791906229d03b4910c59693745f32f76fbb9e46

Issues

Description	From	Last Updated
Function header says message not instance.	ivanhoe	Feb. 23, 2023, 6:45 a.m.
unknown annotation: transfer-full	ivanhoe	Feb. 23, 2023, 6:45 a.m.
instance vs message	ivanhoe	Feb. 23, 2023, 6:46 a.m.
unknown annotation: transfer-none	ivanhoe	Feb. 23, 2023, 6:46 a.m.
Should null check error since g_propagate_error demands it to be non null.	ivanhoe	Feb. 23, 2023, 6:58 a.m.
error belongs to message and should not freed here.	ivanhoe	Feb. 23, 2023, 6:58 a.m.

libpurple/purplemessage.h (Diff revision 1)
The issue has been resolved. Show all issues
```
Function header says message not instance.
```
libpurple/purplemessage.h (Diff revision 1)
The issue has been resolved. Show all issues
```
unknown annotation: transfer-full
```
libpurple/purplemessage.h (Diff revision 1)
The issue has been resolved. Show all issues
```
instance vs message
```
libpurple/purplemessage.h (Diff revision 1)
The issue has been resolved. Show all issues
```
unknown annotation: transfer-none
```

libpurple/purplemessage.c (Diff revision 1)

The issue has been resolved. Show all issues

Should null check error since g_propagate_error demands it to be non null.

libpurple/tests/test_message.c (Diff revision 1)
The issue has been resolved. Show all issues
```
error belongs to message and should not freed here.
```

Change Summary:

rebased and addressed issues

Commits:

	Summary	ID
	Add an error property to PurpleMessage There are a number of ways that an individual message can fail, and it would be nice to let the user interface know that it failed, so that the user can attempt to resend.	74ab691b6d01cb1e35024829b3465b04b8032106
	Add an error property to PurpleMessage There are a number of ways that an individual message can fail, and it would be nice to let the user interface know that it failed, so that the user can attempt to resend.	0791906229d03b4910c59693745f32f76fbb9e46

Diff:

Revision 2 (+352)

Show changes

	libpurple/purplemessage.h
	libpurple/purplemessage.c
	libpurple/tests/meson.build
	libpurple/tests/test_message.c

Ship it!

```
Ship It!
```

Status:: Completed