-
-
-
-
-
-
libpurple/purplemessage.c (Diff revision 1) Should null check
errorsinceg_propagate_errordemands it to be non null. -
libpurple/tests/test_message.c (Diff revision 1) errorbelongs tomessageand should not freed here.
Add an error property to PurpleMessage
Review Request #2234 — Created Feb. 10, 2023 and submitted
| Information | |
|---|---|
| grim | |
| pidgin/pidgin | |
| default | |
| PIDGIN-17757 | |
| Reviewers | |
| pidgin | |
There are a number of ways that an individual message can fail, and it would be nice to let the user interface know that it failed, so that the user can attempt to resend.
Ran the unit tests (that I just added)
| Summary | |
|---|---|
| Description | From | Last Updated |
|---|---|---|
|
Function header says message not instance. |
 ivanhoe
|
|
|
unknown annotation: transfer-full |
ivanhoe
|
|
|
instance vs message |
ivanhoe
|
|
|
unknown annotation: transfer-none |
ivanhoe
|
|
|
Should null check error since g_propagate_error demands it to be non null. |
ivanhoe
|
|
|
error belongs to message and should not freed here. |
ivanhoe
|
Change Summary:
rebased and addressed issues
Commits: |
|
|||||||||
|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+352) |
|||||||||