Summary

IRCv3: Make sure we can compile against old versions of Gsasl

Review Request #2229 — Created Feb. 8, 2023 and submitted Feb. 8, 2023, 2:24 p.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

IRCv3: Make sure we can compile against old versions of Gsasl

Testing Done

Compiled against fedora 36 and 37. Also compiled on debian unstable and verified that SCRAM-SHA-256 was still working.

Commits

Summary	ID
IRCv3: Make sure we can compile against old versions of Gsasl	5b35c943c921b1dbed174e08c8a9979ff34ca73f

Issues

Description	From	Last Updated
This produces a warning for me: ../libpurple/protocols/ircv3/purpleircv3sasl.c: In function 'purple_ircv3_sasl_callback': ../libpurple/protocols/ircv3/purpleircv3sasl.c:114:17: warning: case value '25' not in enumerated type 'Gsasl_property' …	ivanhoe	Feb. 8, 2023, 1:56 p.m.

libpurple/protocols/ircv3/purpleircv3sasl.c (Diff revision 1)

Show all issues

This produces a warning for me:
../libpurple/protocols/ircv3/purpleircv3sasl.c: In function 'purple_ircv3_sasl_callback':
../libpurple/protocols/ircv3/purpleircv3sasl.c:114:17: warning: case value '25' not in enumerated type 'Gsasl_property' [-Wswitch]
  114 |                 case GSASL_CB_TLS_EXPORTER:
      |                 ^~~~

`

grim Feb. 8, 2023, 1:39 p.m.

Hmm, I wonder if we should ignore it or what. It looks like the way to disable it is a pragma for each compiler and that seems like a lot of trouble...

See https://stackoverflow.com/questions/52955811/how-to-disable-enumeration-value-not-explicitly-handled-in-switch-just-for-one

Ship it!

```
Ship It!
```

Review Board 6.0.2

IRCv3: Make sure we can compile against old versions of Gsasl

Information

Reviewers

Status: Closed (submitted)