Convert XmppDiscoService into a GObject

Review Request #2210 — Created Jan. 24, 2023 and submitted

QuLogic
pidgin/pidgin
default
pidgin

This will enable porting things to binding/expression lookup.

I probably didn't really need to make everything properties, but that was easier to do than figure out which ones would really be needed.

Ran discovery on pidgin.im; saw conference.pidgin.im show up, then expanded it and the various rooms appeared, as they should. Clicked Add on a few and verified that the Add Chat dialog appeared with the correct values.

Summary
Convert XmppDiscoService into a GObject
Description From Last Updated

Needs a finalize for the strings.

grimgrim

white space issue

grimgrim

whitespace again

grimgrim

and a few more after whitespace issues after this one too..

grimgrim
grim
grim
  1. 
      
  2. pidgin/plugins/disco/xmppdisco.c (Diff revision 1)
     
     

    🤮

  3. pidgin/plugins/disco/xmppdiscoservice.c (Diff revision 1)
     
     

    Needs a finalize for the strings.

  4. pidgin/plugins/disco/xmppdiscoservice.c (Diff revision 1)
     
     

    white space issue

  5. pidgin/plugins/disco/xmppdiscoservice.c (Diff revision 1)
     
     

    whitespace again

  6. pidgin/plugins/disco/xmppdiscoservice.c (Diff revision 1)
     
     

    and a few more after whitespace issues after this one too..

  7. 
      
QuLogic
QuLogic
grim
  1. Ship It!
  2. Awesome work! Thanks!!

  3. 
      
grim
Review request changed

Status: Closed (submitted)

Loading...