Summary

Convert XmppDiscoService into a GObject

Review Request #2210 — Created Jan. 24, 2023 and submitted Jan. 24, 2023, 9:42 p.m.

Information

Owner

QuLogic

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

This will enable porting things to binding/expression lookup.

I probably didn't really need to make everything properties, but that was easier to do than figure out which ones would really be needed.

Testing Done

Ran discovery on pidgin.im; saw conference.pidgin.im show up, then expanded it and the various rooms appeared, as they should. Clicked Add on a few and verified that the Add Chat dialog appeared with the correct values.

Commits

Summary	ID
Convert XmppDiscoService into a GObject	c570cac5b114351cf93d0875c9017c5c19bbcd89

Issues

Description	From	Last Updated
Needs a finalize for the strings.	grim	Jan. 24, 2023, 9:39 p.m.
white space issue	grim	Jan. 24, 2023, 9:39 p.m.
whitespace again	grim	Jan. 24, 2023, 9:40 p.m.
and a few more after whitespace issues after this one too..	grim	Jan. 24, 2023, 9:40 p.m.

Testing Done:

~		Ran discovery on `pidgin.im`; saw `conference.pidgin.im` show up, then expanded it and the various rooms appeared, as they should. Clicked Add on a few and verified that they Add Chat dialog appeared with the correct values.
	~	Ran discovery on `pidgin.im`; saw `conference.pidgin.im` show up, then expanded it and the various rooms appeared, as they should. Clicked Add on a few and verified that the Add Chat dialog appeared with the correct values.

pidgin/plugins/disco/xmppdisco.c (Diff revision 1)
```
🤮
```
pidgin/plugins/disco/xmppdiscoservice.c (Diff revision 1)
Show all issues
```
Needs a finalize for the strings.
```
pidgin/plugins/disco/xmppdiscoservice.c (Diff revision 1)
Show all issues
```
white space issue
```
pidgin/plugins/disco/xmppdiscoservice.c (Diff revision 1)
Show all issues
```
whitespace again
```
pidgin/plugins/disco/xmppdiscoservice.c (Diff revision 1)
Show all issues
```
and a few more after whitespace issues after this one too..
```

Change Summary:

Fix review issues.

Description:

		This will enable porting things to binding/expression lookup.

~		I probably didn't really need to make everything properties, but that was easier to do than figure out which one's would really be needed.
	~	I probably didn't really need to make everything properties, but that was easier to do than figure out which ones would really be needed.

Commits:

	Summary	ID
	Convert XmppDiscoService into a GObject	881e37d77d5282a32ad907a29895c5a6f3f488e1
	Convert XmppDiscoService into a GObject	bcb0c14a988777b4cec21c91ed67982e207f4c43

Diff:

Revision 2 (+1440 -332)

Show changes

	pidgin/plugins/disco/gtkdisco.c
	pidgin/plugins/disco/meson.build
	pidgin/plugins/disco/xmppdisco.h
	pidgin/plugins/disco/xmppdisco.c
	pidgin/plugins/disco/xmppdiscoservice.h
	pidgin/plugins/disco/xmppdiscoservice.c

Change Summary:

Remove unused 'parent' property. It is only read in one place, and that place just created the XmppDiscoService object, so it has the parent already.

Commits:

	Summary	ID
	Convert XmppDiscoService into a GObject	bcb0c14a988777b4cec21c91ed67982e207f4c43
	Convert XmppDiscoService into a GObject	c570cac5b114351cf93d0875c9017c5c19bbcd89

Diff:

Revision 3 (+1376 -332)

Show changes

	pidgin/plugins/disco/gtkdisco.c
	pidgin/plugins/disco/meson.build
	pidgin/plugins/disco/xmppdisco.h
	pidgin/plugins/disco/xmppdisco.c
	pidgin/plugins/disco/xmppdiscoservice.h
	pidgin/plugins/disco/xmppdiscoservice.c

Ship it!

```
Ship It!
```
```
Awesome work! Thanks!!
```

Review Board 6.0.2

Convert XmppDiscoService into a GObject

Information

Reviewers

Testing Done:

Change Summary:

Description:

Commits:

Diff:

Change Summary:

Commits:

Diff:

Status: Closed (submitted)