Replace GtkTreeView in Build Information with Adwaita widgets

Review Request #2193 — Created Jan. 16, 2023 and submitted

QuLogic
pidgin/pidgin
default
2194
pidgin

I originally put the information in the AdwActionRow's subtitle, but then the important part (in the subtitle) becomes a dim label, which seems wrong.
I also tried an AdwEntryRow instead, which makes the title dim instead, but then you get a weird semi-editable appearance, such as the pencil icon, even when the field is not editable.

So this appearance with a label on the right is similar to the Information section of the General tab in the GTK Inspector.

I also re-arranged the order slightly; it seems like the Meson arguments are the least important so I put them last.

Compiled and opened About dialog.

Summary
Replace GtkTreeView in Build Information with Adwaita widgets

Description From Last Updated

this might be easier to read with GtkWidget *label = gtk_label_new(value); gtk_label_set_use_markup(GTK_LABLE(label), TRUE)); Because not everyone is going to memorize …

grimgrim
grim
  1. 
      
  2. Great work! Thanks!!

  3. pidgin/pidginabout.c (Diff revision 1)
     
     

    this might be easier to read with

    GtkWidget *label = gtk_label_new(value);
    
    gtk_label_set_use_markup(GTK_LABLE(label), TRUE));
    

    Because not everyone is going to memorize that the initial parameter can't be markup without using either set_user_markup or set_markup.

    1. While this might be a bit harder to read, I took a quick cursory glance at how this works internally and setting label to NULL and then using set_markup is waaaaay more efficient.

  4. 
      
grim
  1. Ship It!
  2. 
      
grim
Review request changed

Status: Closed (submitted)

Loading...