Summary

Replace GtkTreeView in Build Information with Adwaita widgets

Review Request #2193 — Created Jan. 16, 2023 and submitted Jan. 16, 2023, 10:03 p.m.

Information

Owner

QuLogic

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Blocks

2194

Reviewers

Groups

pidgin

People

Description

I originally put the information in the AdwActionRow's subtitle, but then the important part (in the subtitle) becomes a dim label, which seems wrong.
I also tried an AdwEntryRow instead, which makes the title dim instead, but then you get a weird semi-editable appearance, such as the pencil icon, even when the field is not editable.

So this appearance with a label on the right is similar to the Information section of the General tab in the GTK Inspector.

I also re-arranged the order slightly; it seems like the Meson arguments are the least important so I put them last.

Testing Done

Compiled and opened About dialog.

Commits

Summary	ID
Replace GtkTreeView in Build Information with Adwaita widgets	c40cb8a07f3825928cd69ae9c8e9b8e3e372311f

Files

Issues

Description	From	Last Updated
this might be easier to read with GtkWidget *label = gtk_label_new(value); gtk_label_set_use_markup(GTK_LABLE(label), TRUE)); Because not everyone is going to memorize …	grim	Jan. 16, 2023, 9:42 p.m.

```
Great work! Thanks!!
```

pidgin/pidginabout.c (Diff revision 1)

The issue has been dropped. Show all issues

this might be easier to read with

GtkWidget *label = gtk_label_new(value);

gtk_label_set_use_markup(GTK_LABLE(label), TRUE));


Because not everyone is going to memorize that the initial parameter can't be markup without using either set_user_markup or set_markup.

grim Jan. 16, 2023, 9:42 p.m.

While this might be a bit harder to read, I took a quick cursory glance at how this works internally and setting label to NULL and then using set_markup is waaaaay more efficient.

Ship it!

```
Ship It!
```

Status:: Completed