Summary

XMPP: Remove STUN lookups

Review Request #2173 — Created Jan. 3, 2023 and submitted Feb. 17, 2023, 10:55 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

While this worked in some regard, it was only refreshed when an account
connected which will lead to caching issues over time.

Also as we're trying to migrate all of the NAT traversal stuff to traversity,
this code was a blocker for removing the STUN code from libpurple itself.

Testing Done

Connected an XMPP account without issue.

Commits

Summary	ID
Remove STUN lookups from XMPP While this worked in some regard, it was only refreshed when an account connected which will lead to caching issues over time. Also as we're trying to migrate all of the NAT traversal stuff to traversity, this code was a blocker for removing the STUN code from libpurple itself.	66f0cd65d1dc73bb73efc0e567348e074b86d564

Change Summary:

rebased

Commits:

	Summary	ID
	Remove STUN lookups from XMPP While this worked in some regard, it was only refreshed when an account connected which will lead to caching issues over time. Also as we're trying to migrate all of the NAT traversal stuff to traversity, this code was a blocker for removing the STUN code from libpurple itself.	19a31f5d0ec5b37977d2dc6f1d01c908bf0e7fab
	Remove STUN lookups from XMPP While this worked in some regard, it was only refreshed when an account connected which will lead to caching issues over time. Also as we're trying to migrate all of the NAT traversal stuff to traversity, this code was a blocker for removing the STUN code from libpurple itself.	66f0cd65d1dc73bb73efc0e567348e074b86d564

Diff:

Revision 2 (+42 -202)

Show changes

	libpurple/protocols/jabber/disco.c
	libpurple/protocols/jabber/jabber.h
	libpurple/protocols/jabber/jabber.c
	libpurple/protocols/jabber/jingle/jingle.c

Summary:

-	Remove STUN lookups from XMPP
+	XMPP: Remove STUN lookups

Ship it!

```
Ship It!
```

Review Board 6.0.2