Summary

Add a name-for-display property to PurpleContactInfo

Review Request #2151 — Created Dec. 23, 2022 and submitted Jan. 6, 2023, 7:54 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

This is a readonly property that is updated when the other properties change.
I also tweaked priorities a bit, a contact info's alias is now the highest
priority to allow users to set an alias on a person, but then also override it
at the contact info level. The use case here is person has an alias of "Pidgy",
but Pidgy's slack account is aliased to "Pidgy (work)".

Testing Done

Ran the unit tests.

Commits

Summary	ID
Add a name-for-display property to PurpleContactInfo This is a readonly property that is updated when the other properties change. I also tweaked priorties a bit, a contact info's alias is now the highest priority to allow users to set an alias on a person, but then also override it at the contact info level. The use case here is person has an alias of "Pidgy", but Pidgy's slack account is aliased to "Pidgy (work)".	d377cd75a013d059155cbd09a1c8627ab2b4beab

Summary

Add a name-for-display property to PurpleContactInfo

This is a readonly property that is updated when the other properties change. I also tweaked priorties a bit, a contact info's alias is now the highest priority to allow users to set an alias on a person, but then also override it at the contact info level. The use case here is person has an alias of "Pidgy", but Pidgy's slack account is aliased to "Pidgy (work)".

d377cd75a013d059155cbd09a1c8627ab2b4beab

Issues

Description	From	Last Updated
char now.	QuLogic	Jan. 6, 2023, 7:46 a.m.
Extra e	QuLogic	Jan. 6, 2023, 7:46 a.m.

Change Summary:

rebased

Commits:

	Summary	ID
	Add a name-for-display property to PurpleContactInfo This is a readonly property that is updated when the other properties change. I also tweaked priorties a bit, a contact info's alias is now the highest priority to allow users to set an alias on a person, but then also override it at the contact info level. The use case here is person has an alias of "Pidgy", but Pidgy's slack account is aliased to "Pidgy (work)".	fb5cd2edb6db7138b088c25a21881dc6a823090b
	Add a name-for-display property to PurpleContactInfo This is a readonly property that is updated when the other properties change. I also tweaked priorties a bit, a contact info's alias is now the highest priority to allow users to set an alias on a person, but then also override it at the contact info level. The use case here is person has an alias of "Pidgy", but Pidgy's slack account is aliased to "Pidgy (work)".	58f59a75b0c787dc63684792dd4186f4872d91a9

Diff:

Revision 2 (+428 -116)

Show changes

	libpurple/purplecontactinfo.h
	libpurple/purplecontactinfo.c
	libpurple/util.h
	libpurple/tests/test_contact_info.c

Change Summary:

Fix typo

Description:

		This is a readonly property that is updated when the other properties change.
~		I also tweaked priorties a bit, a contact info's alias is now the highest
	~	I also tweaked priorities a bit, a contact info's alias is now the highest
		priority to allow users to set an alias on a person, but then also override it
		at the contact info level. The use case here is person has an alias of "Pidgy",
		but Pidgy's slack account is aliased to "Pidgy (work)".

libpurple/purplecontactinfo.c (Diff revision 2)
Show all issues
```
char now.
```
libpurple/util.h (Diff revision 2)
Show all issues
```
Extra e
```

Change Summary:

rebased and addressed issues

Commits:

	Summary	ID
	Add a name-for-display property to PurpleContactInfo This is a readonly property that is updated when the other properties change. I also tweaked priorties a bit, a contact info's alias is now the highest priority to allow users to set an alias on a person, but then also override it at the contact info level. The use case here is person has an alias of "Pidgy", but Pidgy's slack account is aliased to "Pidgy (work)".	58f59a75b0c787dc63684792dd4186f4872d91a9
	Add a name-for-display property to PurpleContactInfo This is a readonly property that is updated when the other properties change. I also tweaked priorties a bit, a contact info's alias is now the highest priority to allow users to set an alias on a person, but then also override it at the contact info level. The use case here is person has an alias of "Pidgy", but Pidgy's slack account is aliased to "Pidgy (work)".	d377cd75a013d059155cbd09a1c8627ab2b4beab

Diff:

Revision 3 (+438 -126)

Show changes

	libpurple/purplecontactinfo.h
	libpurple/purplecontactinfo.c
	libpurple/util.h
	libpurple/tests/test_contact_info.c

Ship it!

```
Ship It!
```

Review Board 6.0.2

Add a name-for-display property to PurpleContactInfo

Information

Reviewers

Change Summary:

Commits:

Diff:

Change Summary:

Description:

Change Summary:

Commits:

Diff:

Status: Closed (submitted)

libpurple/util.h (Diff revision 2)