Summary

Add animation support to PurpleAvatar

Review Request #2141 — Created Dec. 14, 2022 and submitted Jan. 6, 2023, 2:11 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

This drastically changes the way PurpleAvatar works. Previously the idea was
that developers would create a PurpleAvatar and then add it to the
PurpleAvatarManager (which does not exist). But these changes are going to make
it so that developers will either lookup avatars or ask the manager to create
an avatar based on their data.

Testing Done

Ran the unit tests.

Commits

Summary	ID
Add animation support to PurpleAvatar This drastically changed the way PurpleAvatar works. Previously the idea was that developers would create a PurpleAvatar and then add it to the PurpleAvatarManager (which does not exist). But these changes are going to make it so that developers will either lookup avatars or ask the manager to create an avatar based on their data.	9014b81ef4ea87faac1d893cb97d8a95e9b6910f

Issues

Description	From	Last Updated
Add transfer annotation.	QuLogic	Jan. 6, 2023, 1:48 a.m.
static frame? static image?	QuLogic	Jan. 6, 2023, 1:48 a.m.
Not used for anything?	QuLogic	Jan. 6, 2023, 1:58 a.m.

Description:

~		This drastically changed the way PurpleAvatar works. Previously the idea was
	~	This drastically changes the way PurpleAvatar works. Previously the idea was
		that developers would create a PurpleAvatar and then add it to the
		PurpleAvatarManager (which does not exist). But these changes are going to make
		it so that developers will either lookup avatars or ask the manager to create
		an avatar based on their data.

Change Summary:

rebased

Commits:

	Summary	ID
	Add animation support to PurpleAvatar This drastically changed the way PurpleAvatar works. Previously the idea was that developers would create a PurpleAvatar and then add it to the PurpleAvatarManager (which does not exist). But these changes are going to make it so that developers will either lookup avatars or ask the manager to create an avatar based on their data.	dd213f70fbf6b7d6beb2cc7cbd6dd7af54fe984a
	Add animation support to PurpleAvatar This drastically changed the way PurpleAvatar works. Previously the idea was that developers would create a PurpleAvatar and then add it to the PurpleAvatarManager (which does not exist). But these changes are going to make it so that developers will either lookup avatars or ask the manager to create an avatar based on their data.	703d25556a61a46d01ad228bce42f931b95f3c55

Diff:

Revision 2 (+464 -302)

Show changes

	libpurple/purpleavatar.h
	libpurple/purpleavatar.c
	libpurple/tests/meson.build
	libpurple/tests/avatar/animated.gif
	libpurple/tests/avatar/meson.build
	libpurple/tests/avatar/static.png
	libpurple/tests/test_avatar.c
	libpurple/tests/avatar/test_purple_avatar.gresource.xml
	1 more

libpurple/purpleavatar.h (Diff revision 2)
Show all issues
```
Add transfer annotation.
```
libpurple/purpleavatar.c (Diff revision 2)
Show all issues
```
static frame? static image?
```

libpurple/tests/avatar/test_purple_avatar.gresource.xml (Diff revision 2)

Show all issues

Not used for anything?

QuLogic Jan. 6, 2023, 1:48 a.m.
```
Do we need the file itself still?
```

grim Jan. 6, 2023, 1:55 a.m.

We were leaving it in the event that someone would want to recreate the animation.

Change Summary:

rebased and address issues

Commits:

	Summary	ID
	Add animation support to PurpleAvatar This drastically changed the way PurpleAvatar works. Previously the idea was that developers would create a PurpleAvatar and then add it to the PurpleAvatarManager (which does not exist). But these changes are going to make it so that developers will either lookup avatars or ask the manager to create an avatar based on their data.	703d25556a61a46d01ad228bce42f931b95f3c55
	Add animation support to PurpleAvatar This drastically changed the way PurpleAvatar works. Previously the idea was that developers would create a PurpleAvatar and then add it to the PurpleAvatarManager (which does not exist). But these changes are going to make it so that developers will either lookup avatars or ask the manager to create an avatar based on their data.	9014b81ef4ea87faac1d893cb97d8a95e9b6910f

Diff:

Revision 3 (+464 -304)

Show changes

	libpurple/purpleavatar.h
	libpurple/purpleavatar.c
	libpurple/tests/meson.build
	libpurple/tests/avatar/animated.gif
	libpurple/tests/avatar/meson.build
	libpurple/tests/avatar/static.png
	libpurple/tests/test_avatar.c
	libpurple/tests/avatar/test_purple_avatar.gresource.xml
	1 more

Ship it!

```
Ship It!
```

Review Board 6.0.2

Add animation support to PurpleAvatar

Information

Reviewers

Description:

Change Summary:

Commits:

Diff:

Change Summary:

Commits:

Diff:

Status: Closed (submitted)