Summary

Update the reviewboard login stuff to reflect the current state of things.

Review Request #2119 — Created Dec. 11, 2022 and submitted Dec. 12, 2022, 2:42 a.m.

Information

Owner

grim

Repository

imfreedom/contributors-guide

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin-www

People

Description

Update the reviewboard login stuff to reflect the current state of things.

Testing Done

Ran codespell and viewed it in a browser.

Commits

Summary	ID
Update the reviewboard login stuff to reflect the current state of things.	36db0be5cf8c9f822e2f1b1f12415ae9c8051942

Issues

Description	From	Last Updated
Would avoid the (not previously defined) 2fa acronym.	QuLogic	Dec. 12, 2022, 2:41 a.m.
Trailing whitespace.	QuLogic	Dec. 12, 2022, 2:41 a.m.
Bit odd to have the tip in between the following command: and the actual command. Also, I'm not sure that's …	QuLogic	Dec. 12, 2022, 2:41 a.m.

docs/code_contributions.md (Diff revision 1)
The issue has been resolved. Show all issues
```
Would avoid the (not previously defined) 2fa acronym.
```
1. grim Dec. 11, 2022, 11:20 p.m.
  are you saying write it out or ditch it?
2. QuLogic Dec. 11, 2022, 11:37 p.m.
  Write it out.
docs/code_contributions.md (Diff revision 1)
The issue has been resolved. Show all issues
```
Trailing whitespace.
```

docs/code_contributions.md (Diff revision 1)

The issue has been resolved. Show all issues

Bit odd to have the tip in between the following command: and the actual command.

Also, I'm not sure that's enabled in bash by default. It depends on what you've set HISTCONTROL to.

grim Dec. 11, 2022, 11:20 p.m.

Hmm, it's always been on by default for me.

Any suggestions where to put the tip? I was trying to avoid people typing it and then getting pissed it was in their history. I contemplated xclip or something, but since that's os specific avoided it.

QuLogic Dec. 12, 2022, 1:01 a.m.

If it were styled more obviously, it might make sense here, but as it is between the text and command, it seems like you just forgot to write the command.

The space to avoid history is definitely a Debian thing; HISTCONTROL=ignoredups on Fedora here. From /etc/profile:

HISTSIZE=1000
if [ "$HISTCONTROL" = "ignorespace" ] ; then
    export HISTCONTROL=ignoreboth
else
    export HISTCONTROL=ignoredups
fi

grim Dec. 12, 2022, 1:03 a.m.

Looks like it's in my ~/.bashrc too from /etc/skel from a long long time ago

Change Summary:

rebase and address issues, also turned on admonition's to use a nice tip box.

Commits:

	Summary	ID
	Update the reviewboard login stuff to reflect the current state of things.	48e14ae236c1359796fd9a7e6353d494bebfe2ca
	Update the reviewboard login stuff to reflect the current state of things.	36db0be5cf8c9f822e2f1b1f12415ae9c8051942

Diff:

Revision 2 (+58 -16)

Show changes

	mkdocs.yml
	docs/code_contributions.md

Ship it!

```
Ship It!
```

Status:: Completed