Update the reviewboard login stuff to reflect the current state of things.

 






 

 


  Review Request #2119
  —
  Created Dec. 11, 2022 and submitted 

 




















 

  

   Information

  





 
 

  grim
 









 
 

  imfreedom/contributors-guide
 









 
 

  default
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  pidgin-www
 









 
 

  
 






 








 





  


 
 

  
Update the reviewboard login stuff to reflect the current state of things.

 








  


 
 

  
Ran codespell and viewed it in a browser.

 







 









 





  

 


 
 

  



 

  
   


    Summary
    ID

   

  
  

   


    

     
Update the reviewboard login stuff to reflect the current state of things.


    		
    36db0be5cf8c9f822e2f1b1f12415ae9c8051942

   



  
 




 













 






 
 
 

  

   

    

     
    

    
    
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
    

   

   

    
     

      Description
      From
      Last Updated
     

    
    



     

      
       
       
Would avoid the (not previously defined) 2fa acronym.

      		
      
       QuLogicQuLogic
      
      
       
      
     




     

      
       
       
Trailing whitespace.

      		
      
       QuLogicQuLogic
      
      
       
      
     




     

      
       
       
Bit odd to have the tip in between the following command: and the actual command. Also, I'm not sure that's …

      		
      
       QuLogicQuLogic
      
      
       
      
     


    
   

  

 







 






  

 








 














 





 

  

   




QuLogic




   

   







  

 



 

  


   

   

    
 
QuLogic


    
   


  

  

  



    




  1. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 

















  2. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
      docs/code_contributions.md
      


       (Diff revision 1)


      
     
    
    
       
   
    
     
    

    
     
    

       
  
    
 
    

   
    
    
    



    
 
    
  
    
   
   
    
    
     
     
     
     
     
    
    Show all issues
   
  
    
 
    

    



    
    Would avoid the (not previously defined) 2fa acronym.
    
  
    
 
    

 
    
  


    
 
    
 
      

  


    1. 
 
 
      
 
      
  
 
      
 
      
  
      are you saying write it out or ditch it?
      
 
      

      2. 



    2. 
 
 
      
 
      
  
 
      
 
      
  
      Write it out.
      
 
      

      3. 


 
    


    

 
    

    3. 






  3. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
      docs/code_contributions.md
      


       (Diff revision 1)


      
     
    
    
       
   
    
     
    

    
     
    

       
  
    
 
    

   
    
    
    



    
 
    
  
    
   
   
    
    
     
     
     
     
     
    
    Show all issues
   
  
    
 
    

    



    
    Trailing whitespace.
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    4. 






  4. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
      docs/code_contributions.md
      


       (Diff revision 1)


      
     
    
    
       
   
    
     
    

    
     
    

    
     
    

    
     
    

    
     
    

       
  
    
 
    

   
    
    
    



    
 
    
  
    
   
   
    
    
     
     
     
     
     
    
    Show all issues
   
  
    
 
    

    



    
    Bit odd to have the tip in between the following command: and the actual command.
    

    Also, I'm not sure that's enabled in bash by default. It depends on what you've set HISTCONTROL to.
    
  
    
 
    

 
    
  


    
 
    
 
      

  


    1. 
 
 
      
 
      
  
 
      
 
      
  
      Hmm, it's always been on by default for me.
      

      Any suggestions where to put the tip? I was trying to avoid people typing it and then getting pissed it was in their history. I contemplated xclip or something, but since that's os specific avoided it.
      
 
      

      2. 



    2. 
 
 
      
 
      
  
 
      
 
      
  
      If it were styled more obviously, it might make sense here, but as it is between the text and command, it seems like you just forgot to write the command.
      

      The space to avoid history is definitely a Debian thing; HISTCONTROL=ignoredups on Fedora here. From /etc/profile:
      

      HISTSIZE=1000
if [ "$HISTCONTROL" = "ignorespace" ] ; then
    export HISTCONTROL=ignoreboth
else
    export HISTCONTROL=ignoredups
fi

      
 
      

      3. 



    3. 
 
 
      
 
      
  
 
      
 
      
  
      Looks like it's in my ~/.bashrc too from /etc/skel from a long long time ago
      
 
      

      4. 


 
    


    

 
    

    5. 




  5. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    6. 




  

 
















 



 

  

   




grim




   

   

  

 



 















 





 

  

   




QuLogic




   

   







  

 



 

  


   

   

    
 
QuLogic


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Ship It!
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 



 

  

   




grim




   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  






 

  Status:
  

  Closed (submitted)

  
 







 


 










  

 









     

    

   

  

  

   
   Loading...