Summary

Split PurpleContactInfo out of PurpleContact

Review Request #2091 — Created Nov. 24, 2022 and submitted Nov. 29, 2022, 5:53 a.m.

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Groups

People

Description

This change separates all of the data away from the runtime information which
makes it easier to store contacts with everything.

Testing Done

Ran the unit tests and sent a few messages with ircv3 and demo protocols.

Commits

Summary	ID
Split PurpleContactInfo out of PurpleContact This change separates all of the data away from the runtime information which makes it easier to store contacts with everything.	3a5dee18ef5d09d0fc04d01564677c7c3a7e0685

Issues

Description	From	Last Updated
Re-align wrapped lines.	QuLogic	Nov. 29, 2022, 3:44 a.m.
Not sure if you want to go through this file to make the contact into info.	QuLogic	Nov. 29, 2022, 3:49 a.m.
Any reason for doing this differently from the next function?	QuLogic	Nov. 29, 2022, 3:47 a.m.
Should the property name change to match the enumeration name?	QuLogic	Nov. 29, 2022, 3:56 a.m.
Rename to info to match header.	QuLogic	Nov. 29, 2022, 3:56 a.m.
Rename to info to match header.	QuLogic	Nov. 29, 2022, 3:56 a.m.
One more contact -> info?	QuLogic	Nov. 29, 2022, 5:31 a.m.

libpurple/purplecontactinfo.h (Diff revision 1)
The issue has been resolved. Show all issues
```
Re-align wrapped lines.
```
libpurple/purplecontactinfo.c (Diff revision 1)
The issue has been resolved. Show all issues
```
Not sure if you want to go through this file to make the contact into info.
```
libpurple/purplecontactmanager.c (Diff revision 1)
The issue has been resolved. Show all issues
```
Any reason for doing this differently from the next function?
```
libpurple/purpleperson.c (Diff revision 1)
The issue has been resolved. Show all issues
```
Should the property name change to match the enumeration name?
```
libpurple/purpleperson.c (Diff revision 1)
The issue has been resolved. Show all issues
```
Rename to info to match header.
```
libpurple/purpleperson.c (Diff revision 1)
The issue has been resolved. Show all issues
```
Rename to info to match header.
```

Change Summary:

rebase and address issues

Commits:

	Summary	ID
	Split PurpleContactInfo out of PurpleContact This change separates all of the data away from the runtime information which makes it easier to store contacts with everything.	fc6b7bb79196b127116cf732049c87430dbd5be5
	Split PurpleContactInfo out of PurpleContact This change separates all of the data away from the runtime information which makes it easier to store contacts with everything.	bba135eabca491fc3412d25120efa3a04a15d42a

Diff:

Revision 2 (+1116 -3554)

	libpurple/meson.build
	libpurple/purplecontact.h
	libpurple/purplecontact.c
	libpurple/purplecontact.h
	libpurple/purplecontact.c
	libpurple/purplecontactmanager.c
	libpurple/purpleperson.h
	libpurple/purpleperson.c
	6 more

libpurple/purpleperson.c (Diff revision 2)
The issue has been resolved. Show all issues
```
One more contact -> info?
```

Change Summary:

rebase and one more s/contact/info/g

Commits:

	Summary	ID
	Split PurpleContactInfo out of PurpleContact This change separates all of the data away from the runtime information which makes it easier to store contacts with everything.	bba135eabca491fc3412d25120efa3a04a15d42a
	Split PurpleContactInfo out of PurpleContact This change separates all of the data away from the runtime information which makes it easier to store contacts with everything.	3a5dee18ef5d09d0fc04d01564677c7c3a7e0685

Diff:

Revision 3 (+1122 -3560)

	libpurple/meson.build
	libpurple/purplecontact.h
	libpurple/purplecontact.c
	libpurple/purplecontact.h
	libpurple/purplecontact.c
	libpurple/purplecontactmanager.c
	libpurple/purpleperson.h
	libpurple/purpleperson.c
	6 more

Ship it!

libpurple/purpleperson.c (Diff revision 1)

libpurple/purpleperson.c (Diff revision 1)

libpurple/purpleperson.c (Diff revision 1)

libpurple/purpleperson.c (Diff revision 2)