-
-
-
libpurple/purplecontactinfo.c (Diff revision 1) Not sure if you want to go through this file to make the
contactintoinfo. -
libpurple/purplecontactmanager.c (Diff revision 1) Any reason for doing this differently from the next function?
-
libpurple/purpleperson.c (Diff revision 1) Should the property name change to match the enumeration name?
-
-
Split PurpleContactInfo out of PurpleContact
Review Request #2091 — Created Nov. 24, 2022 and submitted
| Information | |
|---|---|
| grim | |
| pidgin/pidgin | |
| default | |
| Reviewers | |
| pidgin | |
This change separates all of the data away from the runtime information which makes it easier to store contacts with everything.
Ran the unit tests and sent a few messages with ircv3 and demo protocols.
| Summary | |
|---|---|
| Description | From | Last Updated |
|---|---|---|
|
Re-align wrapped lines. |
 QuLogic
|
|
|
Not sure if you want to go through this file to make the contact into info. |
QuLogic
|
|
|
Any reason for doing this differently from the next function? |
QuLogic
|
|
|
Should the property name change to match the enumeration name? |
QuLogic
|
|
|
Rename to info to match header. |
QuLogic
|
|
|
Rename to info to match header. |
QuLogic
|
|
|
One more contact -> info? |
QuLogic
|
Change Summary:
rebase and address issues
Commits: |
|
|||||||||
|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+1116 -3554) |
|||||||||
Change Summary:
rebase and one more
s/contact/info/g
Commits: |
|
|||||||||
|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 3 (+1122 -3560) |
|||||||||