Summary

Re-design account manager as a GtkListBox

Review Request #2079 — Created Jan. 16, 2023 and submitted Jan. 17, 2023, 2:30 a.m.

Information

Owner

QuLogic

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

Moves to a nicely spaced GtkListBox. The avatar is implemented using AdwAvatar solely for the autogenerated colour for accounts without an icon to give them some uniqueness, but it could be moved to PidginAvatar.

As a followup, I'd probably move the Account Editors from a separate dialog to stack within the manager, similar to how the Plugin dialog works. Neither the previous manager nor this one prevents you from opening two editors for an account, but this would remove that issue as well.

Testing Done

Toggled enabled/disabled to check that account status worked and was displayed. Added a few bogus accounts to confirm that errors are shown. Activated a row to show the editor. Hit the delete button and cancelled/approved and confirmed that account was kept/removed.

Commits

Summary	ID
Re-design account manager as a GtkListBox	38a278a49a9c4808f3bdebed13d41cb49715b0fc

Files

Issues

Description	From	Last Updated
I'm curious if this is necessary if we connect the items-changed signal before binding the model.	grim	Jan. 17, 2023, 1:56 a.m.
I thought we had to use the gi-docgen linking instead of these now.	grim	Jan. 17, 2023, 2:28 a.m.
need to unref old on else, so i'd just remove the one from line 430 and use g_clear_object on old.	grim	Jan. 17, 2023, 1:57 a.m.

pidgin/pidginaccountmanager.c (Diff revision 1)

The issue has been dropped. Show all issues

I'm curious if this is necessary if we connect the items-changed signal before binding the model.

QuLogic Jan. 17, 2023, 1:29 a.m.

No, this is a signal on the PurpleAccountManager not the GtkListBox.

grim Jan. 17, 2023, 1:57 a.m.
```
Got it!
```

pidgin/pidginaccountrow.h (Diff revision 1)

The issue has been resolved. Show all issues

I thought we had to use the gi-docgen linking instead of these now.

QuLogic Jan. 17, 2023, 1:29 a.m.

That's just for code style that I copied from somewhere or other. I'm not sure we need to link these, as the type is added by gi-docgen?

grim Jan. 17, 2023, 1:57 a.m.

What do you mean the type is added by gi-docgen?

pidgin/pidginaccountrow.c (Diff revision 1)

Doesn't PurpleAccountManager do this? Looks like now, but that's where this code should be. I created PIDGIN-17716 for tracking that.

pidgin/pidginaccountrow.c (Diff revision 1)

The issue has been resolved. Show all issues

need to unref old on else, so i'd just remove the one from line 430 and use g_clear_object on old.

Change Summary:

Fix missing unref.

Commits:

	Summary	ID
	Re-design account manager as a GtkListBox	0eb4b0b3280a9caccbf6da02c3feacb6dd83e950
	Re-design account manager as a GtkListBox	83912641eb555d15274e9a5b9e1c2ee0eef777b7

Diff:

Revision 2 (+1520 -794)

Show changes

	pidgin/meson.build
	pidgin/pidginaccountmanager.c
	pidgin/pidginaccountrow.h
	pidgin/pidginaccountrow.c
	pidgin/resources/pidgin.gresource.xml
	pidgin/resources/Accounts/account-row.ui
	pidgin/resources/Accounts/manager.ui
	po/POTFILES.in

Change Summary:

Clean up docs.

Commits:

	Summary	ID
	Re-design account manager as a GtkListBox	83912641eb555d15274e9a5b9e1c2ee0eef777b7
	Re-design account manager as a GtkListBox	38a278a49a9c4808f3bdebed13d41cb49715b0fc

Diff:

Revision 3 (+1520 -794)

Show changes

	pidgin/meson.build
	pidgin/pidginaccountmanager.c
	pidgin/pidginaccountrow.h
	pidgin/pidginaccountrow.c
	pidgin/resources/pidgin.gresource.xml
	pidgin/resources/Accounts/account-row.ui
	pidgin/resources/Accounts/manager.ui
	po/POTFILES.in

Ship it!

```
Ship It!
```
```
Awesome work, thank you so much!!
```

Status:: Completed