-
-
pidgin/pidginaccountmanager.c (Diff revision 1) I'm curious if this is necessary if we connect the
items-changed
signal before binding the model. -
pidgin/pidginaccountrow.h (Diff revision 1) I thought we had to use the gi-docgen linking instead of these now.
-
pidgin/pidginaccountrow.c (Diff revision 1) Doesn't
PurpleAccountManager
do this? Looks like now, but that's where this code should be. I created PIDGIN-17716 for tracking that. -
pidgin/pidginaccountrow.c (Diff revision 1) need to unref
old
on else, so i'd just remove the one from line 430 and useg_clear_object
onold
.
Re-design account manager as a GtkListBox
Review Request #2079 — Created Jan. 17, 2023 and submitted
Information | |
---|---|
QuLogic | |
pidgin/pidgin | |
default | |
Reviewers | |
pidgin | |
Moves to a nicely spaced
GtkListBox
. The avatar is implemented usingAdwAvatar
solely for the autogenerated colour for accounts without an icon to give them some uniqueness, but it could be moved toPidginAvatar
.As a followup, I'd probably move the Account Editors from a separate dialog to stack within the manager, similar to how the Plugin dialog works. Neither the previous manager nor this one prevents you from opening two editors for an account, but this would remove that issue as well.
Toggled enabled/disabled to check that account status worked and was displayed. Added a few bogus accounts to confirm that errors are shown. Activated a row to show the editor. Hit the delete button and cancelled/approved and confirmed that account was kept/removed.
Summary |
---|
Description | From | Last Updated |
---|---|---|
I'm curious if this is necessary if we connect the items-changed signal before binding the model. |
|
|
I thought we had to use the gi-docgen linking instead of these now. |
|
|
need to unref old on else, so i'd just remove the one from line 430 and use g_clear_object on old. |
|
Change Summary:
Fix missing unref.
Commits: |
|
||||||
---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+1520 -794) |
Change Summary:
Clean up docs.
Commits: |
|
||||||
---|---|---|---|---|---|---|---|
Diff: |
Revision 3 (+1520 -794) |