Summary

Add a contact property to PurpleAccount

Review Request #2064 — Created Nov. 17, 2022 and submitted Nov. 17, 2022, 5:44 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

This contact can be used by the protocol to store additional information about
the account, including the user id, alias, etc. When the protocol connects, it
will be responsible for adding this contact to the ContactManager once it knows
that the id is correct.

This will also be used in the future when PurpleMessage gets migrated to using
PurpleContact's as well.

Testing Done

Connected an IRCv3 and demo accounts.

Commits

Summary	ID
Add a contact property to PurpleAccount This contact can be used by the protocol to store additional information about the account, including the user id, alias, etc. This will also be used in the future when PurpleMessage gets migrated to using PurpleContact's as well.	4e8c591362069019a9e4d30983d6a821ea78e7d9

Issues

Description	From	Last Updated
Would the private values that are bound from PurpleAccount eventually be removed and be made direct aliases for the PurpleContact …	QuLogic	Nov. 17, 2022, 4:32 a.m.
...exposing it is more work...	QuLogic	Nov. 17, 2022, 5:36 a.m.
Semi-unrelated, but is this wrong? It's two colons, and you've used a single colon for the new property.	QuLogic	Nov. 17, 2022, 4:32 a.m.

The issue has been dropped. Show all issues

Would the private values that are bound from PurpleAccount eventually be removed and be made direct aliases for the PurpleContact properties in the future?

grim Nov. 17, 2022, 4:21 a.m.

The intent I was aiming for, is that you would instead get the contact and then use that directly. There is also the option to make a PurpleContactable inteface or something, and both could implement that, but I think that's probably more trouble than it's worth?

QuLogic Nov. 17, 2022, 4:32 a.m.
```
Sounds good.
```

libpurple/account.c (Diff revision 1)
The issue has been resolved. Show all issues
```
...exposing it is more work...
```
1. QuLogic Nov. 17, 2022, 4:33 a.m.
  It was the missing 'is' here...

libpurple/account.c (Diff revision 1)

The issue has been dropped. Show all issues

Semi-unrelated, but is this wrong? It's two colons, and you've used a single colon for the new property.

grim Nov. 17, 2022, 4:21 a.m.

per https://developer-old.gnome.org/gtk-doc-manual/stable/documenting_syntax.html.en, signals are supposed to have :: and properties just : however, there's been confusion on this forever, and our codebase is a total mess when it comes to this. We should probably go through and fix it all at some point.

Change Summary:

fix typo

Commits:

	Summary	ID
	Add a contact property to PurpleAccount This contact can be used by the protocol to store additional information about the account, including the user id, alias, etc. This will also be used in the future when PurpleMessage gets migrated to using PurpleContact's as well.	dfe649ba263c429505349a0da85841c983e09065
	Add a contact property to PurpleAccount This contact can be used by the protocol to store additional information about the account, including the user id, alias, etc. This will also be used in the future when PurpleMessage gets migrated to using PurpleContact's as well.	a91e1f97e03886113ba63282209c74d3ed5bb1cf

Diff:

Revision 2 (+166 -40)

Show changes

	libpurple/account.h
	libpurple/account.c
	libpurple/purplecontact.h
	libpurple/purplecontact.c

Change Summary:

fix typo moar betterer

Commits:

	Summary	ID
	Add a contact property to PurpleAccount This contact can be used by the protocol to store additional information about the account, including the user id, alias, etc. This will also be used in the future when PurpleMessage gets migrated to using PurpleContact's as well.	a91e1f97e03886113ba63282209c74d3ed5bb1cf
	Add a contact property to PurpleAccount This contact can be used by the protocol to store additional information about the account, including the user id, alias, etc. This will also be used in the future when PurpleMessage gets migrated to using PurpleContact's as well.	228f572a83d89bd8a78042c4011476022882598c

Diff:

Revision 3 (+166 -40)

Show changes

	libpurple/account.h
	libpurple/account.c
	libpurple/purplecontact.h
	libpurple/purplecontact.c

Ship it!

```
Ship It!
```

Change Summary:

rebased

Commits:

	Summary	ID
	Add a contact property to PurpleAccount This contact can be used by the protocol to store additional information about the account, including the user id, alias, etc. This will also be used in the future when PurpleMessage gets migrated to using PurpleContact's as well.	228f572a83d89bd8a78042c4011476022882598c
	Add a contact property to PurpleAccount This contact can be used by the protocol to store additional information about the account, including the user id, alias, etc. This will also be used in the future when PurpleMessage gets migrated to using PurpleContact's as well.	4e8c591362069019a9e4d30983d6a821ea78e7d9

Diff:

Revision 4 (+166 -40)

Show changes

	libpurple/account.h
	libpurple/account.c
	libpurple/purplecontact.h
	libpurple/purplecontact.c

Status:: Completed