Add a contact property to PurpleAccount

Review Request #2064 — Created Nov. 16, 2022 and submitted

grim
pidgin/pidgin
default
pidgin

This contact can be used by the protocol to store additional information about
the account, including the user id, alias, etc. When the protocol connects, it
will be responsible for adding this contact to the ContactManager once it knows
that the id is correct.

This will also be used in the future when PurpleMessage gets migrated to using
PurpleContact's as well.

Connected an IRCv3 and demo accounts.

Summary
Add a contact property to PurpleAccount
Description From Last Updated

Would the private values that are bound from PurpleAccount eventually be removed and be made direct aliases for the PurpleContact …

QuLogicQuLogic

...exposing it is more work...

QuLogicQuLogic

Semi-unrelated, but is this wrong? It's two colons, and you've used a single colon for the new property.

QuLogicQuLogic
QuLogic
  1. 
      
  2. Would the private values that are bound from PurpleAccount eventually be removed and be made direct aliases for the PurpleContact properties in the future?

    1. The intent I was aiming for, is that you would instead get the contact and then use that directly. There is also the option to make a PurpleContactable inteface or something, and both could implement that, but I think that's probably more trouble than it's worth?

    2. Sounds good.

  3. libpurple/account.c (Diff revision 1)
     
     

    ...exposing it is more work...

    1. It was the missing 'is' here...

  4. libpurple/account.c (Diff revision 1)
     
     

    Semi-unrelated, but is this wrong? It's two colons, and you've used a single colon for the new property.

    1. per https://developer-old.gnome.org/gtk-doc-manual/stable/documenting_syntax.html.en, signals are supposed to have :: and properties just : however, there's been confusion on this forever, and our codebase is a total mess when it comes to this. We should probably go through and fix it all at some point.

  5. 
      
grim
grim
QuLogic
  1. Ship It!
  2. 
      
grim
grim
Review request changed

Status: Closed (submitted)

Loading...