Add tracking of PersonPerson's to PurpleContactManager

Review Request #2055 — Created Nov. 10, 2022 and updated

grim
pidgin/pidgin
default
pidgin
The manager keeps track of all of this internally but exposes the collection of
people via the GListModel interface and exposes add_person and remove_person as
well.

Ran the unit tests.

Summary
Add tracking of PersonPerson's to PurpleContactManager
Description From Last Updated

Unused.

QuLogicQuLogic

Unused.

QuLogicQuLogic

Are these signals not kind of redundant with the GListModel::items-changed one?

QuLogicQuLogic
grim
QuLogic
  1. 
      
  2. libpurple/purplecontactmanager.c (Diff revision 2)
     
     

    Unused.

  3. libpurple/purplecontactmanager.c (Diff revision 2)
     
     

    Unused.

  4. libpurple/purplecontactmanager.c (Diff revision 2)
     
     

    Are these signals not kind of redundant with the GListModel::items-changed one?

    1. Yes and no? We could probably remove them just fine if we mentioned it in the docs for the object?

  5. 
      
grim
Review request changed

Change Summary:

rebase and add G_GNUC_UNUSED a few times

Commits:

Summary
-
Add tracking of PersonPerson's to PurpleContactManager
+
Add tracking of PersonPerson's to PurpleContactManager

Diff:

Revision 3 (+756 -2)

Show changes

Loading...