Summary

Add tracking of PurplePerson's to PurpleContactManager

Review Request #2055 — Created Nov. 10, 2022 and submitted Dec. 14, 2022, 7:28 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

The manager keeps track of all of this internally but exposes the collection of
people via the GListModel interface and exposes add_person and remove_person as
well.

Testing Done

Ran the unit tests.

Commits

Summary	ID
Add tracking of PersonPerson's to PurpleContactManager The manager keeps track of all of this internally but exposes the collection of people via the GListModel interface and exposes add_person and remove_person as well.	ff5705e3b709bcdad8e47466f460026220689773

Issues

Description	From	Last Updated
Unused.	QuLogic	Dec. 2, 2022, 7:48 a.m.
Unused.	QuLogic	Dec. 2, 2022, 7:48 a.m.
Are these signals not kind of redundant with the GListModel::items-changed one?	QuLogic	Dec. 14, 2022, 7:19 a.m.

Change Summary:

rebased

Commits:

	Summary	ID
	Add tracking of PersonPerson's to PurpleContactManager The manager keeps track of all of this internally but exposes the collection of people via the GListModel interface and exposes add_person and remove_person as well.	25fa51bd62a410ef3e6c41240dab2e37ce7d1524
	Add tracking of PersonPerson's to PurpleContactManager The manager keeps track of all of this internally but exposes the collection of people via the GListModel interface and exposes add_person and remove_person as well.	eaa193cac6b68fe536338d0ba05a7b9980f63f17

Diff:

Revision 2 (+756 -2)

Show changes

	libpurple/purplecontactmanager.h
	libpurple/purplecontactmanager.c
	libpurple/purpleperson.h
	libpurple/purpleperson.c
	libpurple/tests/test_contact_manager.c

libpurple/purplecontactmanager.c (Diff revision 2)
Show all issues
```
Unused.
```
libpurple/purplecontactmanager.c (Diff revision 2)
Show all issues
```
Unused.
```

libpurple/purplecontactmanager.c (Diff revision 2)

Show all issues

Are these signals not kind of redundant with the GListModel::items-changed one?

grim Nov. 29, 2022, 3:03 a.m.

Yes and no? We could probably remove them just fine if we mentioned it in the docs for the object?

grim Dec. 14, 2022, 1:51 a.m.

The main difference though is that we give you the item that was added/removed which is probably easier than figuring out which added/removed via the GListModel signals, which I don't even thing you can do in the case of th removals as it happens after the fact.

Change Summary:

rebase and add G_GNUC_UNUSED a few times

Commits:

	Summary	ID
	Add tracking of PersonPerson's to PurpleContactManager The manager keeps track of all of this internally but exposes the collection of people via the GListModel interface and exposes add_person and remove_person as well.	eaa193cac6b68fe536338d0ba05a7b9980f63f17
	Add tracking of PersonPerson's to PurpleContactManager The manager keeps track of all of this internally but exposes the collection of people via the GListModel interface and exposes add_person and remove_person as well.	df9df0441b4517b5430d5f57495d750f43471747

Diff:

Revision 3 (+756 -2)

Show changes

	libpurple/purplecontactmanager.h
	libpurple/purplecontactmanager.c
	libpurple/purpleperson.h
	libpurple/purpleperson.c
	libpurple/tests/test_contact_manager.c

Change Summary:

rebased and update for PurpleContactInfo

Commits:

	Summary	ID
	Add tracking of PersonPerson's to PurpleContactManager The manager keeps track of all of this internally but exposes the collection of people via the GListModel interface and exposes add_person and remove_person as well.	df9df0441b4517b5430d5f57495d750f43471747
	Add tracking of PersonPerson's to PurpleContactManager The manager keeps track of all of this internally but exposes the collection of people via the GListModel interface and exposes add_person and remove_person as well.	ff5705e3b709bcdad8e47466f460026220689773

Diff:

Revision 4 (+758 -2)

Show changes

	libpurple/purplecontactmanager.h
	libpurple/purplecontactmanager.c
	libpurple/purpleperson.h
	libpurple/purpleperson.c
	libpurple/tests/test_contact_manager.c

Change Summary:

Fix title.

Summary:

-	Add tracking of PersonPerson's to PurpleContactManager
+	Add tracking of PurplePerson's to PurpleContactManager

Ship it!

```
Ship It!
```

Review Board 6.0.2

Add tracking of PurplePerson's to PurpleContactManager

Information

Reviewers

Change Summary:

Commits:

Diff:

Change Summary:

Commits:

Diff:

Change Summary:

Commits:

Diff:

Change Summary:

Summary:

Status: Closed (submitted)