Serialize the ContactManager

Review Request #2054 — Created Nov. 9, 2022 and updated

grim
pidgin/pidgin
default
PIDGIN-17687
pidgin

This is saved in a SQLite database inside the user config directory named
contacts.db. It does its best to synchronize with PurpleBuddy, but not
everything emits a signal when it changes.

Also, stuff like custom avatars are ignored as those are currently store
on the Contact and we don't have a mapping to PurplePerson yet.

Ran with the demo account and verified everything about the contacts was stored via the sqlite3 command line.

Summary
Serialize the ContactManager
Description From Last Updated

Figure out how to handle unit tests. This doens't know when we're testing or not, so it always tries to …

grimgrim

Why is this in the account manager header?

QuLogicQuLogic

NULL works here.

QuLogicQuLogic

name and value are not freed here.

QuLogicQuLogic

name and value are not freed at the end of the loop.

QuLogicQuLogic

Not sure why this calls sync_tags but not update_contact_tags? And should everything get a transaction around it?

QuLogicQuLogic

Ditto.

QuLogicQuLogic

Don't need the semicolon, I think?

QuLogicQuLogic
QuLogic
grim
grim
QuLogic
  1. 
      
  2. libpurple/purpleaccountmanager.h (Diff revision 2)
     
     

    Why is this in the account manager header?

    1. I must have fixed up my open files...

  3. libpurple/purplecontactmanager.c (Diff revision 2)
     
     

    NULL works here.

  4. libpurple/purplecontactmanager.c (Diff revision 2)
     
     

    name and value are not freed here.

    1. They're free'd via the bind method.

      I used the following POC to test. Notice the typo in the statement, you can correct it and verify that we still get double free's for both success and failure.

      #include <glib.h>
      #include <sqlite3.h>
      
      int
      main(int argc, char *argv[]) {
          sqlite3 *db = NULL;
          sqlite3_stmt *stmt = NULL;
          char *bar = NULL;
      
          sqlite3_open(":memory:", &db);
      
          sqlite3_prepare(db, "select * from foo wher bar=?", -1, &stmt, NULL);
      
          bar = g_strdup("allocated string");
      
          sqlite3_bind_text(stmt, 1, bar, -1, g_free);
      
          sqlite3_step(stmt);
      
          g_free(bar);
      
          return 0;
      }
      
    2. Derp, this was supposed to be on the other comment below. This block was leaking.

  5. libpurple/purplecontactmanager.c (Diff revision 2)
     
     

    name and value are not freed at the end of the loop.

    1. They're free'd via the bind method.

    2. See the comment above for why this is already free'd.

  6. libpurple/purplecontactmanager.c (Diff revision 2)
     
     
     
     

    Not sure why this calls sync_tags but not update_contact_tags? And should everything get a transaction around it?

  7. libpurple/purplecontactmanager.c (Diff revision 2)
     
     
     
     
  8. libpurple/purplecontactmanager.c (Diff revision 2)
     
     

    Don't need the semicolon, I think?

  9. 
      
grim
  1. 
      
  2. Figure out how to handle unit tests. This doens't know when we're testing or not, so it always tries to create purple_user_config_dir() / 'contacts.db' which causes failures.

  3. 
      
grim
Review request changed

Change Summary:

rebase and address issues, the unit test failures remain however.

Commits:

Summary
-
Serialize the ContactManager
+
Serialize the ContactManager

Diff:

Revision 3 (+994 -10)

Show changes

Loading...