Change Summary:
Fix typos.
Description: |
|
---|
Review Request #2054 — Created Nov. 10, 2022 and updated
This is saved in a SQLite database inside the user config directory named
contacts.db
. It does its best to synchronize withPurpleBuddy
, but not
everything emits a signal when it changes.Also, stuff like custom avatars are ignored as those are currently store
on the Contact and we don't have a mapping toPurplePerson
yet.
Ran with the demo account and verified everything about the contacts was stored via the sqlite3 command line.
Summary | ID |
---|---|
5ba998bd1b25c115904aab504d80b2fd6531a2a9 |
Description | From | Last Updated |
---|---|---|
Figure out how to handle unit tests. This doens't know when we're testing or not, so it always tries to … |
|
|
Does this need a rebase for PurpleContactInfo stuff? |
|
|
Why is this in the account manager header? |
|
|
NULL works here. |
|
|
name and value are not freed here. |
|
|
name and value are not freed at the end of the loop. |
|
|
Not sure why this calls sync_tags but not update_contact_tags? And should everything get a transaction around it? |
|
|
Ditto. |
|
|
Don't need the semicolon, I think? |
|
|
Extra tab? |
|
|
Would contacts ever change accounts? |
|
|
sqlite3_prepare_v2 is preferred. |
|
|
stmt is not finalized in error or success. |
|
|
stmt is not finalized in error or success. |
|
|
I believe it might be better to prepare this outside the loop, and bind/step inside only. See lifecycle at https://www.sqlite.org/c3ref/stmt.html |
|
|
But if stmt preparation is not moved outside the loop, then this one is not finalized in the case of … |
|
|
But if stmt preparation is not moved outside the loop, then this one is not finalized in the case of … |
|
|
Same here about moving outside loop. |
|
|
Same here about finalizing on success. |
|
|
Can move into the only if that uses it. |
|
|
It's just gpointer. |
|
|
Can be combined into g_clear_list. |
|
Fix typos.
Description: |
|
---|
rebase, just found a bug in the unit tests that needs to be addressed yet.
Commits: |
|
|||||||
---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+974 -10) |
libpurple/purplecontactmanager.c (Diff revision 2) |
---|
name
andvalue
are not freed at the end of the loop.
libpurple/purplecontactmanager.c (Diff revision 2) |
---|
Not sure why this calls
sync_tags
but notupdate_contact_tags
? And should everything get a transaction around it?
rebase and address issues, the unit test failures remain however.
Commits: |
|
|||||||
---|---|---|---|---|---|---|---|---|
Diff: |
Revision 3 (+994 -10) |
rebase, fix whitespace
Commits: |
|
|||||||
---|---|---|---|---|---|---|---|---|
Diff: |
Revision 4 (+994 -10) |
libpurple/purplecontactmanager.c (Diff revision 4) |
---|
I believe it might be better to prepare this outside the loop, and bind/step inside only.
See lifecycle at https://www.sqlite.org/c3ref/stmt.html
libpurple/purplecontactmanager.c (Diff revision 4) |
---|
But if
stmt
preparation is not moved outside the loop, then this one is not finalized in the case of success.
libpurple/purplecontactmanager.c (Diff revision 4) |
---|
But if
stmt
preparation is not moved outside the loop, then this one is not finalized in the case of success.