Summary

Cleanup blist popovers on close

Review Request #2046 — Created Nov. 7, 2022 and submitted Nov. 7, 2022, 11:29 p.m.

Information

Owner

QuLogic

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

Every time you right click on a blist node, a new popover is created. Since
it's attached to the widget, it 'leaks' until the blist is closed, and causes
several warnings when the widget is finalized.

Testing Done

Right clicked on a few nodes, and then closed the buddy list. No warnings about extra children were raised. Also tried a few menu items to make sure they triggered Remove/Set Custom Icon/etc.

Commits

Summary	ID
Cleanup blist popovers on close Every time you right click on a blst entry, a new popover is created. Since it's attached to the widget, it 'leaks' until the blist is closed, and causes several warnings when the widget is finalized.	fbfec6228ed3b9c2360460e011c312bbd7451a8b

Issues

Description	From	Last Updated
need to wrap the call so we can return G_SOURCE_REMOVE when it's called.	grim	Nov. 7, 2022, 11:26 p.m.

pidgin/gtkblist.c (Diff revision 1)

The issue has been resolved. Show all issues

need to wrap the call so we can return G_SOURCE_REMOVE when it's called.

Change Summary:

Fix GSourceFunc types.

Commits:

	Summary	ID
	Cleanup blist popovers on close Every time you right click on a blst entry, a new popover is created. Since it's attached to the widget, it 'leaks' until the blist is closed, and causes several warnings when the widget is finalized.	4706933f89dabb021ec932521f86d758dd2f685d
	Cleanup blist popovers on close Every time you right click on a blst entry, a new popover is created. Since it's attached to the widget, it 'leaks' until the blist is closed, and causes several warnings when the widget is finalized.	fbfec6228ed3b9c2360460e011c312bbd7451a8b

Diff:

Revision 2 (+32)

Show changes

pidgin/gtkblist.c

Ship it!

```
Ship It!
```
```
Awesome work! Thanks!!
```

Status:: Completed