Cleanup blist popovers on close

Review Request #2046 — Created Nov. 7, 2022 and submitted

QuLogic
pidgin/pidgin
default
pidgin

Every time you right click on a blist node, a new popover is created. Since
it's attached to the widget, it 'leaks' until the blist is closed, and causes
several warnings when the widget is finalized.

Right clicked on a few nodes, and then closed the buddy list. No warnings about extra children were raised. Also tried a few menu items to make sure they triggered Remove/Set Custom Icon/etc.

Summary
Cleanup blist popovers on close
Description From Last Updated

need to wrap the call so we can return G_SOURCE_REMOVE when it's called.

grimgrim
grim
  1. 
      
  2. pidgin/gtkblist.c (Diff revision 1)
     
     

    need to wrap the call so we can return G_SOURCE_REMOVE when it's called.

  3. 
      
QuLogic
grim
  1. Ship It!
  2. Awesome work! Thanks!!

  3. 
      
grim
Review request changed

Status: Closed (submitted)

Loading...