Add PurpleAccount::error property and remove "account-error-changed" and "account-status-changing" signals.

Review Request #2036 — Created Nov. 5, 2022 and submitted

grim
pidgin/pidgin
default
pidgin
Also sorted the account signal changes in ChangeLog.API.

The account-error-changed signal is easily replaced by the notify signal for the
new property, and account-status_changing wasn't used by anything.

Used the account actions of the demo protocol plugin to disconnect the account without issue.

Summary
Add PurpleAccount::error property and remove "account-error-changed" and "account-status-changing" signals.
Description From Last Updated

If you're sorting, this should go before account-destroying.

QuLogicQuLogic

We don't really even need old_err as a separate variable now, but this is fine.

QuLogicQuLogic

an error

QuLogicQuLogic
QuLogic
  1. 
      
  2. ChangeLog.API (Diff revision 1)
     
     

    If you're sorting, this should go before account-destroying.

    1. You moved account-destroying after account-disabled instead of moving account-created.

  3. libpurple/account.c (Diff revision 1)
     
     

    We don't really even need old_err as a separate variable now, but this is fine.

  4. libpurple/account.c (Diff revision 1)
     
     

    an error

  5. 
      
grim
grim
QuLogic
  1. Ship It!
  2. 
      
grim
Review request changed

Status: Closed (submitted)

Loading...