Summary

Add PurpleAccount::error property and remove "account-error-changed" and "account-status-changing" signals.

Review Request #2036 — Created Nov. 5, 2022 and submitted Nov. 5, 2022, 7:34 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

Also sorted the account signal changes in ChangeLog.API.

The account-error-changed signal is easily replaced by the notify signal for the
new property, and account-status_changing wasn't used by anything.

Testing Done

Used the account actions of the demo protocol plugin to disconnect the account without issue.

Commits

Summary	ID
Add PurpleAccount::error property and remove "account-error-changed" and "account-status-changing" signals. Also sorted the account signal changes in ChangeLog.API. The account-error-changed signal is easily replaced by the notify signal for the new property, and account-status_changing wasn't used by anything.	b35ccdc0a439b304b18cdbbbdd523356adf0225a

Issues

Description	From	Last Updated
If you're sorting, this should go before account-destroying.	QuLogic	Nov. 5, 2022, 7:18 a.m.
We don't really even need old_err as a separate variable now, but this is fine.	QuLogic	Nov. 5, 2022, 6:59 a.m.
an error	QuLogic	Nov. 5, 2022, 6:59 a.m.

ChangeLog.API (Diff revision 1)

Show all issues

If you're sorting, this should go before account-destroying.

QuLogic Nov. 5, 2022, 7 a.m.

You moved account-destroying after account-disabled instead of moving account-created.

libpurple/account.c (Diff revision 1)

Show all issues

We don't really even need old_err as a separate variable now, but this is fine.

libpurple/account.c (Diff revision 1)
Show all issues
```
an error
```

Change Summary:

address issues

Commits:

	Summary	ID
	Add PurpleAccount::error property and remove "account-error-changed" and "account-status-changing" signals. Also sorted the account signal changes in ChangeLog.API. The account-error-changed signal is easily replaced by the notify signal for the new property, and account-status_changing wasn't used by anything.	8e560b73b3d64d08c02f285b148682d3bd4db91a
	Add PurpleAccount::error property and remove "account-error-changed" and "account-status-changing" signals. Also sorted the account signal changes in ChangeLog.API. The account-error-changed signal is easily replaced by the notify signal for the new property, and account-status_changing wasn't used by anything.	9934a1cbb3902296248873d6063614f39801c7ad

Diff:

Revision 2 (+62 -116)

Show changes

	ChangeLog.API
	doc/reference/libpurple/signals_account.md
	libpurple/account.c
	libpurple/accounts.c
	libpurple/protocols.c

Change Summary:

fix sorting for real this time

Commits:

	Summary	ID
	Add PurpleAccount::error property and remove "account-error-changed" and "account-status-changing" signals. Also sorted the account signal changes in ChangeLog.API. The account-error-changed signal is easily replaced by the notify signal for the new property, and account-status_changing wasn't used by anything.	9934a1cbb3902296248873d6063614f39801c7ad
	Add PurpleAccount::error property and remove "account-error-changed" and "account-status-changing" signals. Also sorted the account signal changes in ChangeLog.API. The account-error-changed signal is easily replaced by the notify signal for the new property, and account-status_changing wasn't used by anything.	b35ccdc0a439b304b18cdbbbdd523356adf0225a

Diff:

Revision 3 (+62 -116)

Show changes

	ChangeLog.API
	doc/reference/libpurple/signals_account.md
	libpurple/account.c
	libpurple/accounts.c
	libpurple/protocols.c

Ship it!

```
Ship It!
```

Review Board 6.0.2

Add PurpleAccount::error property and remove "account-error-changed" and "account-status-changing" signals.

Information

Reviewers

Change Summary:

Commits:

Diff:

Change Summary:

Commits:

Diff:

Status: Closed (submitted)