Summary

Add a filter property to PidginAccountChooser

Review Request #1995 — Created Oct. 29, 2022 and submitted Oct. 29, 2022, 5:53 a.m.

Owner

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Blocks

1992

Groups

People

Description

This replaces the old pidgin_account_chooser_set_filter_func.

It also currently does nothing, but neither did the old code.

Testing Done

Compiled only.

Commits

Summary	ID
Add a filter property to PidginAccountChooser	54d516a0b9a03bd1d181632d13bb070acc5cd3ec

Issues

Description	From	Last Updated
Typically we put the flags on their own line, but I see that's wrong for account too.	grim	Oct. 29, 2022, 5:51 a.m.

Change Summary:

Add unused annotations.

Commits:

	Summary	ID
	Add a filter property to PidginAccountChooser	992b2de9d8ccd737a0826bb32db1c922d1000acc
	Add a filter property to PidginAccountChooser	c8978315ed8713f2488e84362ba581b1dff4d55e

Diff:

Revision 2 (+200 -58)

	pidgin/gtkblist.c
	pidgin/gtkrequest.c
	pidgin/gtkroomlist.c
	pidgin/pidginaccountchooser.h
	pidgin/pidginaccountchooser.c

pidgin/pidginaccountchooser.c (Diff revision 2)

The issue has been resolved. Show all issues

Typically we put the flags on their own line, but I see that's wrong for account too.

Change Summary:

Fix a typo and requested style changes.

Commits:

	Summary	ID
	Add a filter property to PidginAccountChooser	c8978315ed8713f2488e84362ba581b1dff4d55e
	Add a filter property to PidginAccountChooser	54d516a0b9a03bd1d181632d13bb070acc5cd3ec

Diff:

Revision 3 (+206 -60)

	pidgin/gtkblist.c
	pidgin/gtkrequest.c
	pidgin/gtkroomlist.c
	pidgin/pidginaccountchooser.h
	pidgin/pidginaccountchooser.c

Ship it!