Testing Done: |
|
---|
Move PidginAccountChooser to GtkDropDown
Review Request #1992 — Created Oct. 29, 2022 and submitted
Information | |
---|---|
QuLogic | |
pidgin/pidgin | |
default | |
|
|
Reviewers | |
pidgin | |
The chooser connects to the default account manager automatically.
Additionally, re-parent theGtkTreeModelFilter
subclasses toGtkFilter
, and use them on thefilter
property.This also means the previous
filter_func
that was moved toGtkFilter
in /r/1995 are now used again.
Opened most of the affected dialogs. Disabled XMPP account and saw that it was removed from all connected-only filtered choosers. Re-enabled account and it was back in the choosers.
Confirmed that only XMPP, and not Demo accounts appeared in the two XMPP-specific plugins.
Request API is still only compile-tested.
Change Summary:
Add missed unused annotations, and fix a description.
Commits: |
|
||||||
---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+578 -1116) |
Change Summary:
Also convert the Pidgin XMPP plugins to new
PidginAccountChooser
style.
Testing Done: |
|
|||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Commits: |
|
|||||||||||||||
Diff: |
Revision 3 (+622 -1158) |