Move PidginAccountChooser to GtkDropDown

Review Request #1992 — Created Oct. 29, 2022 and submitted

Information

pidgin/pidgin
default

Reviewers

The chooser connects to the default account manager automatically.
Additionally, re-parent the GtkTreeModelFilter subclasses to GtkFilter, and use them on the filter property.

This also means the previous filter_func that was moved to GtkFilter in /r/1995 are now used again.

Opened most of the affected dialogs. Disabled XMPP account and saw that it was removed from all connected-only filtered choosers. Re-enabled account and it was back in the choosers.

Confirmed that only XMPP, and not Demo accounts appeared in the two XMPP-specific plugins.

Request API is still only compile-tested.

Summary ID
Move PidginAccountChooser to GtkDropDown
a52af76ac439bccdefbfd6323638a6ec954e1517
Description From Last Updated

Self isn't used

grimgrim

self isn't used

grimgrim

"protocols with the given id".

grimgrim
grim
grim
  1. 
      
  2. pidgin/pidginaccountchooser.c (Diff revision 1)
     
     
    Show all issues

    Self isn't used

  3. pidgin/pidginaccountchooser.c (Diff revision 1)
     
     
    Show all issues

    self isn't used

  4. pidgin/pidginaccountfilterprotocol.h (Diff revision 1)
     
     
    Show all issues

    "protocols with the given id".

  5. 
      
QuLogic
QuLogic
grim
  1. Ship It!
  2. Great work! Thanks!!

  3. 
      
grim
Review request changed
Status:
Completed