Summary

Move PidginAccountChooser to GtkDropDown

Review Request #1992 — Created Oct. 29, 2022 and submitted Oct. 30, 2022, 8:31 a.m.

Information

Owner

QuLogic

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

~~1998~~, ~~1995~~, ~~1991~~

Reviewers

Groups

pidgin

People

Description

The chooser connects to the default account manager automatically.
Additionally, re-parent the GtkTreeModelFilter subclasses to GtkFilter, and use them on the filter property.

This also means the previous filter_func that was moved to GtkFilter in /r/1995 are now used again.

Testing Done

Opened most of the affected dialogs. Disabled XMPP account and saw that it was removed from all connected-only filtered choosers. Re-enabled account and it was back in the choosers.

Confirmed that only XMPP, and not Demo accounts appeared in the two XMPP-specific plugins.

Request API is still only compile-tested.

Commits

Summary	ID
Move PidginAccountChooser to GtkDropDown	a52af76ac439bccdefbfd6323638a6ec954e1517

Issues

Description	From	Last Updated
Self isn't used	grim	Oct. 30, 2022, 8:23 a.m.
self isn't used	grim	Oct. 30, 2022, 8:23 a.m.
"protocols with the given id".	grim	Oct. 30, 2022, 8:23 a.m.

Testing Done:: Opened most of the affected dialogs. Disabled XMPP account and saw that it was removed from all connected-only filtered choosers. Re-enabled account and it was back in the choosers.

~
Request is still only compile-tested.
~
Request API is still only compile-tested.

pidgin/pidginaccountchooser.c (Diff revision 1)
The issue has been resolved. Show all issues
```
Self isn't used
```
pidgin/pidginaccountchooser.c (Diff revision 1)
The issue has been resolved. Show all issues
```
self isn't used
```
pidgin/pidginaccountfilterprotocol.h (Diff revision 1)
The issue has been resolved. Show all issues
```
"protocols with the given id".
```

Change Summary:

Add missed unused annotations, and fix a description.

Commits:

	Summary	ID
	Move PidginAccountChooser to GtkDropDown	92568839c822626b7e373f4f9478dbe2817447d0
	Move PidginAccountChooser to GtkDropDown	bb575ff2e5504abda443b89a8af7908181da7ba0

Diff:

Revision 2 (+578 -1116)

Show changes

	pidgin/gtkblist.c
	pidgin/gtkprivacy.c
	pidgin/gtkrequest.c
	pidgin/meson.build
	pidgin/pidginaccountchooser.h
	pidgin/pidginaccountchooser.c
	pidgin/pidginaccountfilterconnected.h
	pidgin/pidginaccountfilterconnected.c
	12 more

Change Summary:

Also convert the Pidgin XMPP plugins to new PidginAccountChooser style.

Testing Done:

		Opened most of the affected dialogs. Disabled XMPP account and saw that it was removed from all connected-only filtered choosers. Re-enabled account and it was back in the choosers.

	+	Confirmed that only XMPP, and not Demo accounts appeared in the two XMPP-specific plugins.
	+
		Request API is still only compile-tested.

Commits:

	Summary	ID
	Move PidginAccountChooser to GtkDropDown	bb575ff2e5504abda443b89a8af7908181da7ba0
	Move PidginAccountChooser to GtkDropDown	a52af76ac439bccdefbfd6323638a6ec954e1517

Diff:

Revision 3 (+622 -1158)

Show changes

	pidgin/gtkblist.c
	pidgin/gtkprivacy.c
	pidgin/gtkrequest.c
	pidgin/meson.build
	pidgin/pidginaccountchooser.h
	pidgin/pidginaccountchooser.c
	pidgin/pidginaccountfilterconnected.h
	pidgin/pidginaccountfilterconnected.c
	15 more

Ship it!

```
Ship It!
```
```
Great work! Thanks!!
```

Status:: Completed

		Opened most of the affected dialogs. Disabled XMPP account and saw that it was removed from all connected-only filtered choosers. Re-enabled account and it was back in the choosers.

~		Request is still only compile-tested.
	~	Request API is still only compile-tested.