Convert PidginProxyPrefs to GSettings

Review Request #1990 — Created Oct. 29, 2022 and submitted

Information

pidgin/pidgin
default

Reviewers

This is just the preferences nothing has been done to the actual global proxy options. To configure those you'll need to edit prefs.xml manually until they are updated to gsettings.

I also made the rows in the preferences not focusable and split up pidgin_proxy_prefs_init for readability.

Set all values via the preference page and verified they were saved properly in the prefs file. I also verified the mappings for the type and set all of them via the preference page and verified that it was saved properly in the preference file.

I also manually modified the preferences file and verified that the changes were made immediately in the running program. I also set an invalid value for the type enum, which then fell back to it's default value of "No Proxy".

Summary ID
Convert PidginProxyPrefs to GSettings
b07647b3bfc7492b00d762159017208ad84609c4
Description From Last Updated

If you connect to selected-item, then you'll get the string, I think? So then you don't have to worry about …

QuLogicQuLogic

You can connect to changed::type to get signals for only one key.

QuLogicQuLogic
QuLogic
  1. 
      
  2. pidgin/prefs/pidginproxyprefs.c (Diff revision 1)
     
     

    If you connect to selected-item, then you'll get the string, I think? So then you don't have to worry about keeping the order consistent.

    1. selected item is read only, so I can't set it via that property.

  3. pidgin/prefs/pidginproxyprefs.c (Diff revision 1)
     
     

    You can connect to changed::type to get signals for only one key.

  4. 
      
grim
QuLogic
  1. Ship It!
  2. 
      
grim
Review request changed

Status: Closed (submitted)

Loading...