Summary

Move PurpleAccountManager to GPtrArray and implement GListModel

Review Request #1987 — Created Oct. 28, 2022 and submitted Oct. 28, 2022, 8:45 a.m.

Information

Owner

QuLogic

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

Move PurpleAccountManager to GPtrArray and implement GListModel

Testing Done

Compiled and ran ninja test. Opened Account Manager and Privacy Dialog to check that account list seemed okay.

Commits

Summary	ID
Move PurpleAccountManager to GPtrArray and implement GListModel	b6402d0d7a9f6265c16d501c4778155528b8ebbd

Issues

Description	From	Last Updated
other option? Delete this functionality, I'd be on board for that.	grim	Oct. 28, 2022, 8:40 a.m.
maybe add a purple_account_manager_get_default_as_model function?	grim	Oct. 28, 2022, 8:40 a.m.

finch/gntaccount.c (Diff revision 1)

I wonder if we want to either move this into purple_account_manager_reorder or add a purple_account_manager_move which takes a relative position to move the account.

libpurple/purpleaccountmanager.c (Diff revision 1)

Weird that this doesn't unref, but I'm keeping previous behaviour.

Change Summary:

Fix missing unrefs, and some small stylistic things.

Commits:

	Summary	ID
	Move PurpleAccountManager to GPtrArray and implement GListModel	65e5880cdbf6e72ccbbe09fb1127097429a5197a
	Move PurpleAccountManager to GPtrArray and implement GListModel	3143aaf2d9a8be19f9f65aaf4316f6566e335f39

Diff:

Revision 2 (+434 -304)

Show changes

	finch/gntaccount.c
	finch/gntrequest.c
	finch/gntstatus.c
	libpurple/buddylist.c
	libpurple/purpleaccountmanager.h
	libpurple/purpleaccountmanager.c
	libpurple/util.c
	libpurple/tests/test_account_manager.c
	1 more

finch/gntaccount.c (Diff revision 1)

The issue has been dropped. Show all issues

other option? Delete this functionality, I'd be on board for that.

finch/gntrequest.c (Diff revision 1)
The issue has been resolved. Show all issues
```
maybe add a purple_account_manager_get_default_as_model function?
```
libpurple/purpleaccountmanager.c (Diff revision 1)
```
this might be a bug?
```

libpurple/purpleaccountmanager.c (Diff revision 1)

We might want make this return a GListStore later.

Change Summary:

Add purple_account_manager_get_default_as_model and fix some unused variables.

Commits:

	Summary	ID
	Move PurpleAccountManager to GPtrArray and implement GListModel	3143aaf2d9a8be19f9f65aaf4316f6566e335f39
	Move PurpleAccountManager to GPtrArray and implement GListModel	b6402d0d7a9f6265c16d501c4778155528b8ebbd

Diff:

Revision 3 (+466 -306)

Show changes

	finch/gntaccount.c
	finch/gntrequest.c
	finch/gntstatus.c
	libpurple/buddylist.c
	libpurple/purpleaccountmanager.h
	libpurple/purpleaccountmanager.c
	libpurple/util.c
	libpurple/tests/test_account_manager.c
	1 more

```
Great work, thanks!!
```

Ship it!

```
Ship It!
```

Status:: Completed