-
-
finch/gntaccount.c (Diff revision 1) I wonder if we want to either move this into
purple_account_manager_reorder
or add apurple_account_manager_move
which takes a relative position to move the account. -
libpurple/purpleaccountmanager.c (Diff revision 1) Weird that this doesn't unref, but I'm keeping previous behaviour.
Move PurpleAccountManager to GPtrArray and implement GListModel
Review Request #1987 — Created Oct. 28, 2022 and submitted
Information | |
---|---|
QuLogic | |
pidgin/pidgin | |
default | |
Reviewers | |
pidgin | |
Move
PurpleAccountManager
toGPtrArray
and implementGListModel
Compiled and ran
ninja test
. Opened Account Manager and Privacy Dialog to check that account list seemed okay.
Change Summary:
Fix missing unrefs, and some small stylistic things.
Commits: |
|
||||||
---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+434 -304) |
-
-
finch/gntaccount.c (Diff revision 1) other option? Delete this functionality, I'd be on board for that.
-
finch/gntrequest.c (Diff revision 1) maybe add a
purple_account_manager_get_default_as_model
function? -
-
libpurple/purpleaccountmanager.c (Diff revision 1) We might want make this return a
GListStore
later.
Change Summary:
Add
purple_account_manager_get_default_as_model
and fix some unused variables.
Commits: |
|
||||||
---|---|---|---|---|---|---|---|
Diff: |
Revision 3 (+466 -306) |