Summary

Fix an issue where XMPP accounts weren't reading passwords from the credential manager

Review Request #1969 — Created Oct. 26, 2022 and submitted Oct. 28, 2022, 8:43 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

XMPP has passwords set to optional because of the SASL implementation. However,
the fallback for that SASL implementation wasn't checking the credential manager
for a password which lead to a prompt for the password. This patch corrects that
behavior.

Testing Done

Connected an XMPP account with the require password account option set to FALSE with a password stored in the active credential provider and verified that it successfully logged into without prompting for a password.

Commits

Summary	ID
Fix an issue where XMPP accounts weren't reading passwords from the credential manager XMPP has passwords set to optional because of the SASL implementation. However, the fallback for that SASL implementation wasn't checking the credential manager for a password which lead to a prompt for the password. This patch corrects that behavior.	2d984405b70d108cee4897ff245c21f441df26d3

Issues

Description	From	Last Updated
Weird indent.	QuLogic	Oct. 28, 2022, 8:38 a.m.

libpurple/protocols/jabber/auth.c (Diff revision 1)

Shouldn't the password be purple_str_wipe'd here too?

libpurple/protocols/jabber/auth_cyrus.c (Diff revision 1)
Show all issues
```
Weird indent.
```

Change Summary:

address issues

Commits:

	Summary	ID
	Fix an issue where XMPP accounts weren't reading passwords from the credential manager XMPP has passwords set to optional because of the SASL implementation. However, the fallback for that SASL implementation wasn't checking the credential manager for a password which lead to a prompt for the password. This patch corrects that behavior.	39585dd24b4c18680bf6f63d178a77c42a58565d
	Fix an issue where XMPP accounts weren't reading passwords from the credential manager XMPP has passwords set to optional because of the SASL implementation. However, the fallback for that SASL implementation wasn't checking the credential manager for a password which lead to a prompt for the password. This patch corrects that behavior.	2d984405b70d108cee4897ff245c21f441df26d3

Diff:

Revision 2 (+264 -12)

Show changes

	libpurple/connection.h
	libpurple/connection.c
	libpurple/protocols/jabber/auth.c
	libpurple/protocols/jabber/auth_cyrus.c

Ship it!

```
Ship It!
```

Review Board 6.0.2