-
-
-
libpurple/purplesqlite3.h (Diff revision 1) I thought we didn't put
(out)
on errors because it did nothing. -
-
libpurple/purplesqlite3.h (Diff revision 1) There's a word or something missing at the beginning of this sentence.
I also don't understand what you mean by a "full" migration, as it seems like the second entry in the below example is a "partial" schema since it only contains 1->2 changes, but then it's still an incremental migration for each step, and not a full one, unless full has some specific DB meaning.
Also, since you begin a transaction around the migration, you may want to mention not needing that here.
-
-
-
libpurple/purplesqlite3.c (Diff revision 1) Since the transaction is deferred, is there really no chance of an error in the
COMMIT
? -
Add some api for handling SQLite3 migrations
Review Request #1906 — Created Oct. 7, 2022 and submitted
Also port the SqliteHistoryAdapter to the new api.
Ran the unit tests under valgrind and checked out code coverage which is really just missing error handling I can't test.
Summary | ID |
---|---|
7c39089da3afc2bc0090629e37ccb5eaf083eb70 |
Description | From | Last Updated |
---|---|---|
An |
QuLogic | |
I thought we didn't put (out) on errors because it did nothing. |
QuLogic | |
its |
QuLogic | |
There's a word or something missing at the beginning of this sentence. I also don't understand what you mean by … |
QuLogic | |
creates |
QuLogic | |
its |
QuLogic | |
s/is to be/to be/ |
QuLogic | |
s/Which of course/This/ |
QuLogic | |
Since the transaction is deferred, is there really no chance of an error in the COMMIT? |
QuLogic | |
I don't know what 'pretend write' means here. |
QuLogic | |
OK, I do know why you do i+1, but this comment is confusing because it doesn't have anything to do … |
QuLogic |
Change Summary:
address everything i didn't comment on here.
Commits: |
|
|||||||
---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+1786 -64) |
Change Summary:
grossly simplify running the actual migrations.
Commits: |
|
|||||||
---|---|---|---|---|---|---|---|---|
Diff: |
Revision 3 (+1698 -64) |
Change Summary:
drop
(out)
annotations
Commits: |
|
|||||||
---|---|---|---|---|---|---|---|---|
Diff: |
Revision 4 (+1698 -64) |
-
-
-
-
libpurple/purplesqlite3.c (Diff revisions 1 - 2) OK, I do know why you do
i+1
, but this comment is confusing because it doesn't have anything to do with short circuiting thefor
loop. Thefor
loop checksmigrations[i]
, andversion
doesn't even exist as part of the loop condition.
Change Summary:
fix some typos reword some things
Commits: |
|
|||||||
---|---|---|---|---|---|---|---|---|
Diff: |
Revision 5 (+1700 -64) |