Summary

Create and add PurpleContacts to the manager when purple_buddy_new is called

Review Request #1873 — Created Sept. 30, 2022 and submitted Oct. 1, 2022, 6:52 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

PIDGIN-17685

Depends On

Reviewers

Groups

pidgin

People

Description

This required some additional changes to PurpleContact. Namely that the contact always has a presence and it is no longer writeable.

Testing Done

Ran the unit tests and verified nothing funky happens when running.

We can't test that all of the properties are properly bound because we would have to start up a lot more of libpurple than I'm willing to do for something that's temporary.

Commits

Summary	ID
Create and add PurpleContacts to the manager when purple_buddy_new is called	9ee57b44f48a0a348c260ab3ff3b0ced3b3676a8

Issues

Description	From	Last Updated
meant	lifesfaded	Sept. 30, 2022, 11:46 p.m.
username	lifesfaded	Sept. 30, 2022, 11:46 p.m.
Isn't there a prototype for this to remove as well?	QuLogic	Oct. 1, 2022, 6:36 a.m.
its	QuLogic	Oct. 1, 2022, 6:36 a.m.
Can combine to g_value_take_object	QuLogic	Oct. 1, 2022, 6:36 a.m.
its	QuLogic	Oct. 1, 2022, 6:36 a.m.
Should this not be added to statuses?	QuLogic	Oct. 1, 2022, 6:36 a.m.
let's	QuLogic	Oct. 1, 2022, 6:36 a.m.

Description:: ~
Create and add PurpleContacts to the manager when purple_buddy_new is called
~
This required some additional changes to PurpleContact. Namely that the contact always has a presence and it is no longer writeable.

libpurple/purplecontactmanager.h (Diff revision 1)
The issue has been resolved. Show all issues
```
meant
```
libpurple/tests/test_contact_manager.c (Diff revision 1)
The issue has been resolved. Show all issues
```
username
```

Change Summary:

fixed some typos

Commits:

	Summary	ID
	Create and add PurpleContacts to the manager when purple_buddy_new is called	e90b5a7c3a3030c062c59ff77b9c2295d118207c
	Create and add PurpleContacts to the manager when purple_buddy_new is called	5470d94ecfc1609e9175387462414c6cea25d503

Diff:

Revision 2 (+510 -128)

Show changes

	libpurple/buddy.c
	libpurple/purplecontact.c
	libpurple/purplecontactmanager.h
	libpurple/purplecontactmanager.c
	libpurple/purpleperson.c
	libpurple/tests/test_contact.c
	libpurple/tests/test_contact_manager.c
	libpurple/tests/test_person.c

libpurple/purplecontact.c (Diff revision 2)
The issue has been resolved. Show all issues
```
Isn't there a prototype for this to remove as well?
```
libpurple/purplecontactmanager.h (Diff revision 2)
The issue has been resolved. Show all issues
```
its
```
libpurple/purplecontactmanager.c (Diff revision 2)
The issue has been resolved. Show all issues
```
Can combine to g_value_take_object
```
libpurple/purplecontactmanager.c (Diff revision 2)
The issue has been resolved. Show all issues
```
its
```

libpurple/tests/test_contact_manager.c (Diff revision 2)

The issue has been resolved. Show all issues

Should this not be added to statuses?

grim Oct. 1, 2022, 6:03 a.m.

Yes, but we don't actually use it, because changing status for a buddy is requires a bunch of libpurple to be running. There's a comment further down in the test.

Regardless, I'll remove this type.

libpurple/tests/test_contact_manager.c (Diff revision 2)
The issue has been resolved. Show all issues
```
let's
```

Change Summary:

rebase and address issues.

Commits:

	Summary	ID
	Create and add PurpleContacts to the manager when purple_buddy_new is called	5470d94ecfc1609e9175387462414c6cea25d503
	Create and add PurpleContacts to the manager when purple_buddy_new is called	9ee57b44f48a0a348c260ab3ff3b0ced3b3676a8

Diff:

Revision 3 (+502 -156)

Show changes

	libpurple/buddy.c
	libpurple/purplecontact.h
	libpurple/purplecontact.c
	libpurple/purplecontactmanager.h
	libpurple/purplecontactmanager.c
	libpurple/purpleperson.c
	libpurple/tests/test_contact.c
	libpurple/tests/test_contact_manager.c
	1 more

Ship it!

```
Ship It!
```

Status:: Completed