Create and add PurpleContacts to the manager when purple_buddy_new is called

Review Request #1873 — Created Sept. 30, 2022 and submitted

Information

pidgin/pidgin
default

Reviewers

This required some additional changes to PurpleContact. Namely that the contact always has a presence and it is no longer writeable.

Ran the unit tests and verified nothing funky happens when running.

We can't test that all of the properties are properly bound because we would have to start up a lot more of libpurple than I'm willing to do for something that's temporary.

Summary ID
Create and add PurpleContacts to the manager when purple_buddy_new is called
9ee57b44f48a0a348c260ab3ff3b0ced3b3676a8
Description From Last Updated

meant

lifesfadedlifesfaded

username

lifesfadedlifesfaded

Isn't there a prototype for this to remove as well?

QuLogicQuLogic

its

QuLogicQuLogic

Can combine to g_value_take_object

QuLogicQuLogic

its

QuLogicQuLogic

Should this not be added to statuses?

QuLogicQuLogic

let's

QuLogicQuLogic
grim
lifesfaded
  1. 
      
  2. libpurple/purplecontactmanager.h (Diff revision 1)
     
     
  3. libpurple/tests/test_contact_manager.c (Diff revision 1)
     
     

    username

  4. 
      
grim
QuLogic
  1. 
      
  2. libpurple/purplecontact.c (Diff revision 2)
     
     

    Isn't there a prototype for this to remove as well?

  3. libpurple/purplecontactmanager.c (Diff revision 2)
     
     
     
     

    Can combine to g_value_take_object

  4. libpurple/tests/test_contact_manager.c (Diff revision 2)
     
     
     

    Should this not be added to statuses?

    1. Yes, but we don't actually use it, because changing status for a buddy is requires a bunch of libpurple to be running. There's a comment further down in the test.

      Regardless, I'll remove this type.

  5. 
      
grim
QuLogic
  1. Ship It!
  2. 
      
grim
Review request changed

Status: Closed (submitted)

Loading...