Summary

Add all of the purple preferences to our gschema

Review Request #1866 — Created Sept. 30, 2022 and submitted Oct. 1, 2022, 6:50 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

There's a number of preferences we will be dropping and a few that we will be
adding with this change. Of those that are dropping, some will be moved to
plugins instead.

Testing Done

Compiled the schema

Commits

Summary	ID
Add all of the purple preferences to our gschema There's a number of preferences we will be dropping and a few that we will be adding with this change. Of those that are dropping, some will be moved to plugins instead.	ae0270ad20542489573404b87ef0eef2dda5b797

Issues

Description	From	Last Updated
This is a Pidgin pref?	QuLogic	Oct. 1, 2022, 4:11 a.m.
This is a Pidgin pref?	QuLogic	Oct. 1, 2022, 4:11 a.m.
Other summaries don't have trailing periods. Probably can remove 'The' as well.	QuLogic	Oct. 1, 2022, 4:11 a.m.
s/amount of//	QuLogic	Oct. 1, 2022, 4:11 a.m.
port	QuLogic	Oct. 1, 2022, 4:11 a.m.
STUN	QuLogic	Oct. 1, 2022, 6:37 a.m.
How will it become 5349 if the default is 3478?	QuLogic	Oct. 1, 2022, 6:37 a.m.
These can be fully capitalized if you want.	QuLogic	Oct. 1, 2022, 4:11 a.m.

libpurple/data/im.pidgin.Purple.gschema.xml (Diff revision 1)
The issue has been resolved. Show all issues
```
This is a Pidgin pref?
```
libpurple/data/im.pidgin.Purple.gschema.xml (Diff revision 1)
The issue has been resolved. Show all issues
```
This is a Pidgin pref?
```
libpurple/data/im.pidgin.Purple.gschema.xml (Diff revision 1)
The issue has been resolved. Show all issues
```
Other summaries don't have trailing periods. Probably can remove 'The' as well.
```
libpurple/data/im.pidgin.Purple.gschema.xml (Diff revision 1)
The issue has been resolved. Show all issues
```
s/amount of//
```
libpurple/data/im.pidgin.Purple.gschema.xml (Diff revision 1)
The issue has been resolved. Show all issues
```
port
```

libpurple/data/im.pidgin.Purple.gschema.xml (Diff revision 1)

The issue has been resolved. Show all issues

STUN

grim Sept. 30, 2022, 8:26 a.m.

STUNS is STUN Secured, that is over TLS.

QuLogic Oct. 1, 2022, 4:13 a.m.

I did not see a STUNS acronym in the RFC or Wikipedia page for STUN.

grim Oct. 1, 2022, 4:56 a.m.

Search for this:



An application may automatically determine a suitable STUN server for communications with a particular peer by querying the Domain Name System (DNS) for the stun (for UDP) or stuns (for TCP/TLS) server (SRV) resource record, e.g., _stun._udp.example.com.

QuLogic Oct. 1, 2022, 5:34 a.m.

That is the name of a DNS record for applications to automatically find the server. The method is still STUN.

libpurple/data/im.pidgin.Purple.gschema.xml (Diff revision 1)

The issue has been resolved. Show all issues

How will it become 5349 if the default is 3478?

grim Sept. 30, 2022, 8:26 a.m.
```
We have to code that part..
```

QuLogic Oct. 1, 2022, 4:11 a.m.

What I mean is, how will we differentiate between 3478 the default and 3478 set by a user? I guess we could check g_settings_get_user_value, maybe.

grim Oct. 1, 2022, 4:56 a.m.
```
Maybe we should just have a TLS toggle?
```

QuLogic Oct. 1, 2022, 5:34 a.m.

You've already added a TLS toggle, so we're good there. It is nice to auto pick the right port if never modified, but we can leave that for now, and just remove the second default from the docs?

libpurple/data/im.pidgin.Purple.gschema.xml (Diff revision 1)
The issue has been resolved. Show all issues
```
These can be fully capitalized if you want.
```

Change Summary:

Address issues

Commits:

	Summary	ID
	Add all of the purple preferences to our gschema There's a number of preferences we will be dropping and a few that we will be adding with this change. Of those that are dropping, some will be moved to plugins instead.	fb7314160d73a4b9b0bea6ba584ce28bdfcb63a8
	Add all of the purple preferences to our gschema There's a number of preferences we will be dropping and a few that we will be adding with this change. Of those that are dropping, some will be moved to plugins instead.	0e7f4a821962eda4302b0d04d4ae2bee8e18d34b

Diff:

Revision 2 (+564)

Show changes

libpurple/data/im.pidgin.Purple.gschema.xml

Change Summary:

rebase and remove STUNS mention and TLS port

Commits:

	Summary	ID
	Add all of the purple preferences to our gschema There's a number of preferences we will be dropping and a few that we will be adding with this change. Of those that are dropping, some will be moved to plugins instead.	0e7f4a821962eda4302b0d04d4ae2bee8e18d34b
	Add all of the purple preferences to our gschema There's a number of preferences we will be dropping and a few that we will be adding with this change. Of those that are dropping, some will be moved to plugins instead.	ae0270ad20542489573404b87ef0eef2dda5b797

Diff:

Revision 3 (+564)

Show changes

libpurple/data/im.pidgin.Purple.gschema.xml

Ship it!

```
Ship It!
```

Status:: Completed