Add all of the purple preferences to our gschema

Review Request #1866 — Created Sept. 30, 2022 and submitted

Information

pidgin/pidgin
default

Reviewers

There's a number of preferences we will be dropping and a few that we will be
adding with this change. Of those that are dropping, some will be moved to
plugins instead.

Compiled the schema

Summary ID
Add all of the purple preferences to our gschema
There's a number of preferences we will be dropping and a few that we will be adding with this change. Of those that are dropping, some will be moved to plugins instead.
ae0270ad20542489573404b87ef0eef2dda5b797
Description From Last Updated

This is a Pidgin pref?

QuLogicQuLogic

This is a Pidgin pref?

QuLogicQuLogic

Other summaries don't have trailing periods. Probably can remove 'The' as well.

QuLogicQuLogic

s/amount of//

QuLogicQuLogic

port

QuLogicQuLogic

STUN

QuLogicQuLogic

How will it become 5349 if the default is 3478?

QuLogicQuLogic

These can be fully capitalized if you want.

QuLogicQuLogic
QuLogic
  1. 
      
  2. This is a Pidgin pref?

  3. This is a Pidgin pref?

  4. Other summaries don't have trailing periods. Probably can remove 'The' as well.

  5. s/amount of//

    1. STUNS is STUN Secured, that is over TLS.

    2. I did not see a STUNS acronym in the RFC or Wikipedia page for STUN.

    3. Search for this:

      An application may automatically determine a suitable STUN server for communications with a particular peer by querying the Domain Name System (DNS) for the stun (for UDP) or stuns (for TCP/TLS) server (SRV) resource record, e.g., _stun._udp.example.com.

    4. That is the name of a DNS record for applications to automatically find the server. The method is still STUN.

  6. How will it become 5349 if the default is 3478?

    1. We have to code that part..

    2. What I mean is, how will we differentiate between 3478 the default and 3478 set by a user? I guess we could check g_settings_get_user_value, maybe.

    3. Maybe we should just have a TLS toggle?

    4. You've already added a TLS toggle, so we're good there. It is nice to auto pick the right port if never modified, but we can leave that for now, and just remove the second default from the docs?

  7. libpurple/data/im.pidgin.Purple.gschema.xml (Diff revision 1)
     
     
     
     

    These can be fully capitalized if you want.

  8. 
      
grim
grim
QuLogic
  1. Ship It!
  2. 
      
grim
Review request changed

Status: Closed (submitted)

Loading...