- Download Diff

Summary:

Create the new PurpleContact

Review Request #1828 — Created Sept. 23, 2022 and submitted Sept. 23, 2022, 8:48 a.m.

Information
Owner:	grim
Repository:	pidgin/pidgin
Branch:	default
Bugs:	PIDGIN-17663
Depends On:
Reviewers
Groups:	pidgin
People:

Description

Create the new PurpleContact

Testing Done

Ran the unit tests and ninja pidgin-pot

Commits

Summary
Create the new PurpleContact

Screenshots

Issues

Description	From	Last Updated
Did you want to add a GUID for the contact like in PurpleBuddy?	QuLogic	Sept. 23, 2022, 8:35 a.m.
Extra 'where'	QuLogic	Sept. 23, 2022, 8:29 a.m.
But there's no id argument to new?	QuLogic	Sept. 23, 2022, 8:45 a.m.
can change	QuLogic	Sept. 23, 2022, 8:30 a.m.
By the contact or by the prpl? This seems contradictory, but might have misunderstood.	QuLogic	Sept. 23, 2022, 8:30 a.m.
controlled by	QuLogic	Sept. 23, 2022, 8:30 a.m.
Double 'maybe be'. Also, 'if it allows'	QuLogic	Sept. 23, 2022, 8:30 a.m.

Change Summary:

add a readonly tags property.

Commits:

	Summary
-	Create the new PurpleContact
+	Create the new PurpleContact

Diff:

Revision 2 (+1448)

Show changes

	libpurple/meson.build
	libpurple/purplecontact.h
	libpurple/purplecontact.c
	libpurple/tests/meson.build
	libpurple/tests/test_contact.c
	po/POTFILES.in

Show all issues

Did you want to add a GUID for the contact like in PurpleBuddy?

libpurple/purplecontact.h (Diff revision 2)
Show all issues
```
Extra 'where'
```
libpurple/purplecontact.c (Diff revision 2)
Show all issues
```
can change
```

libpurple/purplecontact.c (Diff revision 2)

Show all issues

By the contact or by the prpl? This seems contradictory, but might have misunderstood.

libpurple/purplecontact.c (Diff revision 2)
Show all issues
```
controlled by
```
libpurple/purplecontact.c (Diff revision 2)
Show all issues
```
Double 'maybe be'. Also, 'if it allows'
```

Change Summary:

Address issues.

Commits:

	Summary
-	Create the new PurpleContact
+	Create the new PurpleContact

Diff:

Revision 3 (+1598)

Show changes

	libpurple/meson.build
	libpurple/purplecontact.h
	libpurple/purplecontact.c
	libpurple/tests/meson.build
	libpurple/tests/test_contact.c
	po/POTFILES.in

libpurple/purplecontact.h (Diff revisions 2 - 3)
Show all issues
```
But there's no id argument to new?
```

Change Summary:

fix _get_id documentation

Commits:

	Summary
-	Create the new PurpleContact
+	Create the new PurpleContact

Diff:

Revision 4 (+1602)

Show changes

	libpurple/meson.build
	libpurple/purplecontact.h
	libpurple/purplecontact.c
	libpurple/tests/meson.build
	libpurple/tests/test_contact.c
	po/POTFILES.in

Ship it!

```
Ship It!
```

You have a pending review.

Review Board 5.0.6

Create the new PurpleContact

Change Summary:

Commits:

Diff:

Change Summary:

Commits:

Diff:

Change Summary:

Commits:

Diff:

Status: Closed (submitted)