Summary

Move the existing refresh code to GPluginFileSource

Review Request #1788 — Created Sept. 18, 2022 and submitted Sept. 25, 2022, 5:48 a.m.

Information

Owner

grim

Repository

gplugin/gplugin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

I was hoping this would required a bit less tweaking, but it's functionally the
same as the unit tests pass, but things got weird because we're using the
GObject life cycle to mimic stuff we just had scoped differently in the preivous
version.

Testing Done

Ran the unittests, pulled some hair out, complained on stream...

Commits

Summary	ID
Move the existing refresh code to GPluginFileSource I was hoping this would required a bit less tweaking, but it's functionally the same as the unit tests pass, but things got weird because we're using the GObject life cycle to mimic stuff we just had scoped differently in the preivous version.	1bcf543dfe084108afe6c0f3db63d98375382b3f

Issues

Description	From	Last Updated
Braces.	QuLogic	Sept. 25, 2022, 5:26 a.m.
Can't happen, no	QuLogic	Sept. 25, 2022, 5:26 a.m.
Also not possible?	QuLogic	Sept. 25, 2022, 5:26 a.m.
back	QuLogic	Sept. 25, 2022, 5:26 a.m.
Not adding loaders here.	QuLogic	Sept. 25, 2022, 5:27 a.m.
But this returns gchar* not a const gchar*, so it's already a duplicate, isn't it? Also not using a "view", …	QuLogic	Sept. 25, 2022, 5:27 a.m.
Braces.	QuLogic	Sept. 25, 2022, 5:27 a.m.
The plugin_filenames hash table is keyed ...	QuLogic	Sept. 25, 2022, 5:27 a.m.
Extra 'called by'	QuLogic	Sept. 25, 2022, 5:28 a.m.
Looking for duplicates is in the scanner, but would it be better here?	QuLogic	Sept. 25, 2022, 5:28 a.m.

gplugin/gplugin-file-source.c (Diff revision 1)
The issue has been resolved. Show all issues
```
Braces.
```
gplugin/gplugin-file-source.c (Diff revision 1)
The issue has been resolved. Show all issues
```
Can't happen, no
```
1. grim Sept. 25, 2022, 4:28 a.m.
  You're right, this should only be called from a GPluginFileSource object.
gplugin/gplugin-file-source.c (Diff revision 1)
The issue has been resolved. Show all issues
```
Also not possible?
```
gplugin/gplugin-file-source.c (Diff revision 1)
The issue has been resolved. Show all issues
```
back
```
gplugin/gplugin-file-source.c (Diff revision 1)
The issue has been resolved. Show all issues
```
Not adding loaders here.
```

gplugin/gplugin-file-source.c (Diff revision 1)

The issue has been resolved. Show all issues

But this returns gchar* not a const gchar*, so it's already a duplicate, isn't it?
Also not using a "view", so this comment seems quite outdated.

gplugin/gplugin-file-source.c (Diff revision 1)
The issue has been resolved. Show all issues
```
Braces.
```
gplugin/gplugin-file-source.c (Diff revision 1)
The issue has been resolved. Show all issues
```
The plugin_filenames hash table is keyed ...
```
gplugin/gplugin-manager.c (Diff revision 1)
The issue has been resolved. Show all issues
```
Extra 'called by'
```

gplugin/gplugin-manager.c (Diff revision 1)

The issue has been dropped. Show all issues

Looking for duplicates is in the scanner, but would it be better here?

grim Sept. 25, 2022, 4:45 a.m.

We probably want to leave this here for now, as the statically loaded plugins won't have a filename, which we're going to have to tackle in a different fashion anyways. So for now, lets let the scanner handle their own deduplication.

Change Summary:

address issues

Commits:

	Summary	ID
	Move the existing refresh code to GPluginFileSource I was hoping this would required a bit less tweaking, but it's functionally the same as the unit tests pass, but things got weird because we're using the GObject life cycle to mimic stuff we just had scoped differently in the preivous version.	a54cf7c43cdcf035b17f530e6579db912a906302
	Move the existing refresh code to GPluginFileSource I was hoping this would required a bit less tweaking, but it's functionally the same as the unit tests pass, but things got weird because we're using the GObject life cycle to mimic stuff we just had scoped differently in the preivous version.	1bcf543dfe084108afe6c0f3db63d98375382b3f

Diff:

Revision 2 (+1388 -668)

Show changes

	gplugin/gplugin-file-source.h
	gplugin/gplugin-file-source.c
	gplugin/gplugin-manager.c
	gplugin/gplugin-private.h
	gplugin/meson.build
	gplugin/tests/test-native-loader.c

Ship it!

```
Ship It!
```

Status:: Completed

Ship it!

```
Ship It!
```