Move the existing refresh code to GPluginFileSource

Review Request #1788 — Created Sept. 18, 2022 and submitted

grim
gplugin/gplugin
default
pidgin
I was hoping this would required a bit less tweaking, but it's functionally the
same as the unit tests pass, but things got weird because we're using the
GObject life cycle to mimic stuff we just had scoped differently in the preivous
version.

Ran the unittests, pulled some hair out, complained on stream...

Summary
Move the existing refresh code to GPluginFileSource
Description From Last Updated

Braces.

QuLogicQuLogic

Can't happen, no

QuLogicQuLogic

Also not possible?

QuLogicQuLogic

back

QuLogicQuLogic

Not adding loaders here.

QuLogicQuLogic

But this returns gchar* not a const gchar*, so it's already a duplicate, isn't it? Also not using a "view", …

QuLogicQuLogic

Braces.

QuLogicQuLogic

The plugin_filenames hash table is keyed ...

QuLogicQuLogic

Extra 'called by'

QuLogicQuLogic

Looking for duplicates is in the scanner, but would it be better here?

QuLogicQuLogic
QuLogic
  1. 
      
  2. gplugin/gplugin-file-source.c (Diff revision 1)
     
     
     

    Braces.

  3. gplugin/gplugin-file-source.c (Diff revision 1)
     
     

    Can't happen, no

    1. You're right, this should only be called from a GPluginFileSource object.

  4. gplugin/gplugin-file-source.c (Diff revision 1)
     
     

    Also not possible?

  5. gplugin/gplugin-file-source.c (Diff revision 1)
     
     
  6. gplugin/gplugin-file-source.c (Diff revision 1)
     
     
     
     

    Not adding loaders here.

  7. gplugin/gplugin-file-source.c (Diff revision 1)
     
     
     
     
     

    But this returns gchar* not a const gchar*, so it's already a duplicate, isn't it?

    Also not using a "view", so this comment seems quite outdated.

  8. gplugin/gplugin-file-source.c (Diff revision 1)
     
     
     

    Braces.

  9. gplugin/gplugin-file-source.c (Diff revision 1)
     
     

    The plugin_filenames hash table is keyed ...

  10. gplugin/gplugin-manager.c (Diff revision 1)
     
     

    Extra 'called by'

  11. gplugin/gplugin-manager.c (Diff revision 1)
     
     
     
     

    Looking for duplicates is in the scanner, but would it be better here?

    1. We probably want to leave this here for now, as the statically loaded plugins won't have a filename, which we're going to have to tackle in a different fashion anyways. So for now, lets let the scanner handle their own deduplication.

  12. 
      
grim
QuLogic
  1. Ship It!
  2. 
      
grim
Review request changed

Status: Closed (submitted)

QuLogic
  1. Ship It!
  2. 
      
Loading...