Summary

Convert the protocol chooser to a GtkDropDown

Review Request #1723 — Created Sept. 6, 2022 and submitted Sept. 6, 2022, 2:45 a.m.

Information

Owner

QuLogic

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

~~1722~~, ~~1719~~

Blocks

1724

Reviewers

Groups

pidgin

People

Description

This effectively looks the same, but the factory and expression are more general, and this can be ported to an AdwComboRow almost directly (literally just s/GtkDropDown/AdwComboRow//g and s/gtk_drop_down/adw_combo_row/g), if that's the route we end up with for the account settings.

Testing Done

Opened a new account dialog, changed protocols and saw that things changed a bit, also tried on an existing account.

Commits

Summary	ID
Convert the protocol chooser to a GtkDropDown	053683f1d0f982113ad1d01ee248be560617468f

Issues

Description	From	Last Updated
does this just select the parent? it's weird seeing a class name and not an id is what i'm getting …	grim	Sept. 6, 2022, 2:39 a.m.

pidgin/resources/Protocols/chooser.ui (Diff revision 1)

The issue has been resolved. Show all issues

does this just select the parent? it's weird seeing a class name and not an id is what i'm getting at.

QuLogic Sept. 6, 2022, 2:25 a.m.

It picks the template from the nested xml; it's like adding object="PidginProtocolChooser" in the <signal> handler.

grim Sept. 6, 2022, 2:39 a.m.

Got it, thanks! I was over looking that it was a template and that's the only way to reference it as a template.

Ship it!

```
Ship It!
```
```
Nice work, thanks!
```

Status:: Completed