Convert the protocol chooser to a GtkDropDown

Review Request #1723 — Created Sept. 6, 2022 and submitted

Information
QuLogic
pidgin/pidgin
default
1722, 1719
1724
Reviewers
pidgin 
This effectively looks the same, but the factory and expression are more general, and this can be ported to an AdwComboRow almost directly (literally just s/GtkDropDown/AdwComboRow//g and s/gtk_drop_down/adw_combo_row/g), if that's the route we end up with for the account settings.
Opened a new account dialog, changed protocols and saw that things changed a bit, also tried on an existing account.
Summary 
Convert the protocol chooser to a GtkDropDown
Description From Last Updated

does this just select the parent? it's weird seeing a class name and not an id is what i'm getting …

 grimgrim
grim
grim 
  1. 
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 

















  2. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
      pidgin/resources/Protocols/chooser.ui
      


       (Diff revision 1)


      
     
    
    
       
   
    
     
    

    
     
    

       
  
    
 
    

   
    
    
    



    
 
    
  
    
   
   
    
    
     
     
     
     
     
    
    Show all issues
   
  
    
 
    

    



    
    does this just select the parent? it's weird seeing a class name and not an id is what i'm getting at.
    
  
    
 
    

 
    
  


    
 
    
 
      

  


    1. 
 
 
      
 
      
  
 
      
 
      
  
      It picks the template from the nested xml; it's like adding object="PidginProtocolChooser" in the <signal> handler.
      
 
      

      2. 



    2. 
 
 
      
 
      
  
 
      
 
      
  
      Got it, thanks! I was over looking that it was a template and that's the only way to reference it as a template.
      
 
      

      3. 


 
    


    

 
    

    3. 




  3. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    4. 




  

 
















 





 

  

   




grim




   

   







  

 



 

  


   

   

    
 
grim


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Ship It!
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 







  2. 
 
    
  
  
    
  
   
    
    
    




    
    Nice work, thanks!
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 













  3. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    4. 




  

 
















 



 

  

   




grim




   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  






 

  Status:
  

  Closed (submitted)

  
 







 


 










  

 









     

    

   

  

  

   
   Loading...